Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more comprehensive profiler docs #344

Merged
merged 1 commit into from Feb 20, 2022
Merged

Add more comprehensive profiler docs #344

merged 1 commit into from Feb 20, 2022

Conversation

PragTob
Copy link
Member

@PragTob PragTob commented Feb 20, 2022

@pablocostass if you had a bit of time to review these it'd be appreciated but of course not needed :)

pablocostass
pablocostass approved these changes Feb 20, 2022
View reviewed changes
Copy link
Contributor

@pablocostass pablocostass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for documenting that feature in the README! 💜
I tots forgot to add a section for it back in the day

@PragTob
Copy link
Member Author

PragTob commented Feb 20, 2022

You did add very detailed config docs though but all good, it's also more my job as maintainer to think of this :)

@PragTob PragTob merged commit 65b4476 into main Feb 20, 2022
@PragTob PragTob deleted the profiler-docs branch February 20, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablocostass pablocostass pablocostass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PragTob @pablocostass