Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning #424

Merged
merged 1 commit into from Feb 26, 2024
Merged

Conversation

mhanberg
Copy link
Contributor

No description provided.

@PragTob
Copy link
Member

PragTob commented Feb 26, 2024

The what now? It's running 26.2 why doesn't it have the JIT enabled? MacOS ._.

  1) test .jit_enabled? should say true for versions > 24.0.0 (Benchee.SystemTest)
     test/benchee/system_test.exs:146
     Expected truthy, got false
     code: assert jit_enabled?
     stacktrace:
       test/benchee/system_test.exs:152: (test)

@PragTob
Copy link
Member

PragTob commented Feb 26, 2024

@mhanberg thanks a lot for the MR, when/how do you trigger the deprecation warning?

I don't see it on tests or a simple example:

Erlang/OTP 26 [erts-14.2.1] [source] [64-bit] [smp:16:16] [ds:16:16:10] [async-threads:1] [jit:ns]

Elixir 1.16.1 (compiled with Erlang/OTP 26)

@mhanberg
Copy link
Contributor Author

Oh, sorry. It must be a deprecation on 1.17.

I've had to run Elixir main branch on a couple projects and that's where I saw it.

Feel free to close if you'd like to wait for 1.17 to release.

@PragTob
Copy link
Member

PragTob commented Feb 26, 2024

@mhanberg nah I love it, thank you very much! 💚

Normally the CI pipeline etc. should just catch it though. Might be a nice sign that I should include some level of testing against elixir master and not fail the build but notify me on failures or something.

I'll check it out, on the train right now though 😁

@PragTob
Copy link
Member

PragTob commented Feb 26, 2024

Confirmed getting the error on main 😎

Thanks!

@PragTob
Copy link
Member

PragTob commented Feb 26, 2024

Merging although a test is failing, but that's confirmed nothing to do with the PR but the elixir/erlang from brew on mac I wager... ._.

@PragTob PragTob merged commit 2d56fba into bencheeorg:main Feb 26, 2024
21 of 22 checks passed
@mhanberg mhanberg deleted the deprecation-warning branch February 26, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants