Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Begin refactoring of Benchmark module #93

Closed
wants to merge 1 commit into from
Closed

WIP - Begin refactoring of Benchmark module #93

wants to merge 1 commit into from

Commits on Jun 23, 2017

  1. WIP - Begin refactoring of Benchmark module

    This is a non-functional, very eary, broken step in the process. I'm
    just putting it up now to get some feedback before continuing.
    
    While I was working on adding the memory usage information, it struck
    me that it would be a lot easier to add that without major changes if
    there was already a struct representing an individual benchmark that I
    could add it to. I decided to explore this refactoring a bit, and after
    this initial step I kind of like it.
    
    Basically, I split the `Benchee.Benchmark` module into two parts -
    `Benchee.Benchmark`, which handles creating the benchmark structs and
    passing them along to the actual functions that will run the benchmarks,
    and another module (`Benchee.Benchmark.Runner`) that handles the actual
    running of the benchmarks.
    
    So, what do folks think? It made sense to me since we already had a
    struct for a `Suite` of benchmarks.
    devonestes committed Jun 23, 2017
    Copy the full SHA
    be85270 View commit details
    Browse the repository at this point in the history