Skip to content

Commit

Permalink
Random plotly.js update that seems to work
Browse files Browse the repository at this point in the history
  • Loading branch information
PragTob committed Dec 10, 2023
1 parent 54a11b3 commit 1f78442
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 81 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -11,6 +11,7 @@ Memory blowing up on formatting? Try `sequential_output/2`!

### Features
* Introduce `sequential_output/2` which you can can call as a function in formatters. Instead of formatting _everything_ first and then writing it out it will format one HTML file and immediately write it out freeing it up for Garabage Collection. This can lead to huge max memory used savings (12 GB --> 7 GB in a bigger benchmark I ran).
* Graphing library (plotly.js) updated, seems to work graphs may look slightly different.

## 1.0.0 (2019-03-28)

Expand Down
78 changes: 0 additions & 78 deletions priv/assets/javascripts/plotly-1.30.1.min.js

This file was deleted.

8 changes: 8 additions & 0 deletions priv/assets/javascripts/plotly-2.27.0.min.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions priv/templates/partials/js_includes.html.eex
Expand Up @@ -2,9 +2,9 @@
<script>
<% javascripts_path = Application.app_dir(:benchee_html, "priv/assets/javascripts/") %>
<%= File.read! Path.join(javascripts_path, "benchee.js") %>
<%= File.read! Path.join(javascripts_path, "plotly-1.30.1.min.js") %>
<%= File.read! Path.join(javascripts_path, "plotly-2.27.0.min.js") %>
</script>
<% else %>
<script src="assets/javascripts/plotly-1.30.1.min.js"></script>
<script src="assets/javascripts/plotly-2.27.0.min.js"></script>
<script src="assets/javascripts/benchee.js"></script>
<% end %>
2 changes: 1 addition & 1 deletion test/benchee/formatters/html_test.exs
Expand Up @@ -228,7 +228,7 @@ defmodule Benchee.Formatters.HTMLTest do
refute File.exists?("#{@test_directory}/assets/fontello/css/fontello.css")

refute File.exists?("#{@test_directory}/assets/javascripts/benchee.js")
refute File.exists?("#{@test_directory}/assets/javascripts/plotly-1.30.1.min.js")
refute File.exists?("#{@test_directory}/assets/javascripts/plotly-2.27.0.min.js")
after
if File.exists?(@test_directory), do: File.rm_rf!(@test_directory)
end
Expand Down

0 comments on commit 1f78442

Please sign in to comment.