Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[agent][central] Get the ip address of the node (myself) #18

Closed
at15 opened this issue Feb 26, 2018 · 1 comment
Closed

[agent][central] Get the ip address of the node (myself) #18

at15 opened this issue Feb 26, 2018 · 1 comment
Labels
type/wontfix This will not be worked on
Projects
Central Agent
Milestone
Week 8

Comments

@at15
Copy link
Member

at15 commented Feb 26, 2018 •
edited

Previously I was thinking agent can know its own address after it made a successful request to central, (which is normally how I know my ip address ....http://ip.taobao.com/ but this may not be ideal, we can pass the ip when start the process for sure, but the provision script must have an ip assigned to the node at first and know how to get it ...

Ref
@at15 at15 added this to the Week 7 milestone Feb 26, 2018
@at15 at15 added this to To do in Central via automation Feb 26, 2018
@at15 at15 added this to To do in Agent via automation Feb 26, 2018
at15 added a commit that referenced this issue Feb 26, 2018
@at15
[common][nodeutil] Add GetNode
d86e3f9 
- returns machine capacity, process start time, machine boot time
- [ ] TODO: addr #18
@at15 at15 modified the milestones: Week 7, Week 8 Feb 27, 2018
at15 added a commit that referenced this issue Mar 3, 2018
@at15
[central] Formalize node information
c111850 
- central set remoteAddr in response to node register, so it knows its
own ip address in server's view
  - this is a hack because we haven't implement obtain ip address of the
client itself on the client side #18
@at15 at15 mentioned this issue Mar 4, 2018
Merged
at15 added a commit that referenced this issue Mar 4, 2018
@at15
Merge pull request #24 from benchhub/central/register-agent/cron
ce6fc25 
[central][agent] Retry if register node failed 

- agent would retry if register fail, and switch to heartbeat if success (NOTE: heartbeat is not implemented yet ...)
- central would fill remoteAddr into agent's node info as a workaround before #18 
- ui add page for node, simply showing JSON, no type check, the proto is not yet settled for node info 
- vagrant forward 6091 to host, so it can be used with ui
@at15
Copy link
Member Author

at15 commented May 17, 2018

this may also work https://stackoverflow.com/questions/23558425/how-do-i-get-the-local-ip-address-in-go

@at15 at15 added the type/wontfix This will not be worked on label Feb 4, 2020
@at15 at15 closed this as completed Feb 4, 2020
Central automation moved this from To do to Done Feb 4, 2020
Agent automation moved this from To do to Done Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/wontfix This will not be worked on
Projects
No open projects
Agent
  
Done
Central
  
Done
Milestone
Week 8
Development

No branches or pull requests
1 participant
@at15