Display 1-dimensional table in benchie show (closes #16) #24
Conversation
| CliCommand::Show { row, col, metric } => match (row, col, metric) { | ||
| (Some(row), Some(col), Some(metric)) => show_2d_table(row, col, metric), | ||
| (Some(row), _, Some(metric)) => show_1d_table(row, metric), | ||
| _ => show(), |
There was a problem hiding this comment.
FYI: A way to make this a bit more easy to understand, you could also split CliCommand::Show in CliCommand::Show, CliComnmand::Show1dTable and CliCommand::Show2dTable. Therefore only specific permutations of row, col and metric are allowed by construction. But it is OK as you implemented it, because the argument parsing should limit the allowed permutations anyway.
There was a problem hiding this comment.
Indeed I also considered this kind of solution but wasn’t sure if it’s better or not atm 🤔 .
|
Ah one additional comment: It's good to split unit tests in very small function, such that you can test them independently. And the name of the unit test function is the most important one. Because it should describe, what constrain you are testing. E.g. |
|
Done. |
No description provided.