Skip to content

Commit

Permalink
temporary: try alert comment
Browse files Browse the repository at this point in the history
  • Loading branch information
rhysd committed Nov 20, 2019
1 parent dcbee47 commit 077dde1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ jobs:
output-file-path: examples/go/output.txt
skip-fetch-gh-pages: true
fail-on-alert: true
github-token: ${{ secrets.GITHUB_TOKEN }}
comment-on-alert: true
alert-comment-cc-users: '@rhysd'
- run: node ./scripts/ci_validate_modification.js before_data.js 'Go Benchmark'
benchmarkjs:
name: Run JavaScript benchmark example
Expand Down
4 changes: 2 additions & 2 deletions examples/go/fib_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ import (

func BenchmarkFib10(b *testing.B) {
for i := 0; i < b.N; i++ {
var _ = Fib(10)
var _ = Fib(13)
}
}

func BenchmarkFib20(b *testing.B) {
for i := 0; i < b.N; i++ {
var _ = Fib(20)
var _ = Fib(23)
}
}

1 comment on commit 077dde1

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert!! ⚠️

Possible performance regression was detected for benchmark 'Go Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 077dde1 Previous: 70e31dc Ratio
BenchmarkFib10 1977 ns/op 454 ns/op 4.354625550660793
BenchmarkFib20 260855 ns/op 57073 ns/op 4.570549997371787

This comment was automatically generated by workflow using github-action-benchmark.

CC: @rhysd

Please sign in to comment.