Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more characters in Golang bench outputs #131

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

vaeryn-uk
Copy link
Contributor

This adds , and = as acceptable characters as Go benchmark names. Previously benchmarks with these character were not detected by this action.

I've run across this problem specifically using table benchmarks, where there are multiple changing variables per benchmark. foo=bar,baz=qux feels like a natural name for these, e.g.

BenchmarkWorldTick/agentCount=1,interactableCount=1,stationary=0,awarenessRange_2000-16                    69483             16465 ns/op
BenchmarkWorldTick/agentCount=20,interactableCount=10,stationary=50,awarenessRange_2000-16                   589           2140095 ns/op
BenchmarkWorldTick/agentCount=200,interactableCount=100,stationary=100,awarenessRange_60-16                  194           5987727 ns/op
BenchmarkWorldTick/agentCount=200,interactableCount=100,stationary=100,awarenessRange_120-16                 174           6981772 ns/op
BenchmarkWorldTick/agentCount=200,interactableCount=100,stationary=100,awarenessRange_240-16                 100          10206439 ns/op
BenchmarkWorldTick/agentCount=1000,interactableCount=100,stationary=100,awarenessRange_30-16                  24          47655071 ns/op

This adds , and = as acceptable characters as Go benchmark names.
Previously benchmarks with these character were not detected by this
action.
Copy link

@matthargett matthargett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test! LGTM

Copy link
Member

@ktrz ktrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @vaeryn-uk!

@ktrz ktrz merged commit 5d67cdc into benchmark-action:master Apr 26, 2023
21 checks passed
@ktrz
Copy link
Member

ktrz commented Apr 26, 2023

released in v1.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants