Fix/go tabled benchmarks

[kaancfidan]

Extended regex to also include tabled benchmarks.

Fixes #31

[kaancfidan]

See https://regex101.com/r/kOwwOf/1 for a quick look at the effects of the regex change.

[jimeh]

Any chance this could be merged soon? :)

[kaancfidan]

Any chance this could be merged soon? :)

Evidently, no.

[kaancfidan]

@rhysd could you point out any potential issues with this PR?

[jimeh]

For now, I've worked around this by hackily renaming the benchmark names, replacing Benchmark/ with Benchmark__, and also replacing = and - characters with _:

      - name: Run benchmarks
        run: make bench | tee output.raw
      - name: Fix benchmark names
        run: >-
          perl -pe 's/^(Benchmark.+?)\/(\S+)(-\d+)(\s+)/\1__\2\4/' output.raw |
          tr '=-' '_' | tee output.txt
      - name: Store benchmark result
        uses: rhysd/github-action-benchmark@v1
        with:
          tool: "go"
          output-file-path: output.txt
          github-token: ${{ secrets.GH_PUSH_TOKEN }}
          comment-on-alert: true
          auto-push: true

Full source is here.

[kaancfidan]

For now, I've worked around this by hackily renaming the benchmark names, replacing Benchmark/ with Benchmark__, and also replacing = and - characters with _:

      - name: Run benchmarks
        run: make bench | tee output.raw
      - name: Fix benchmark names
        run: >-
          perl -pe 's/^(Benchmark.+?)\/(\S+)(-\d+)(\s+)/\1__\2\4/' output.raw |
          tr '=-' '_' | tee output.txt
      - name: Store benchmark result
        uses: rhysd/github-action-benchmark@v1
        with:
          tool: "go"
          output-file-path: output.txt
          github-token: ${{ secrets.GH_PUSH_TOKEN }}
          comment-on-alert: true
          auto-push: true

Full source is here.

That's neat and sad at the same time.

[isdevx]

Gentle ping on this, I can confirm this PR does not have any regressions so far cc/@ktrz @rhysd

[ktrz]

Thank you for your contribution 👍🏼 I've added a couple of suggestions. Let me know what do you think

[isdevx]

pinging @kaancfidan this time :)

[kaancfidan]

pinging @kaancfidan this time :)

I had stopped hoping this PR would get merged and somehow missed it got attention.

[ktrz]

Thanks, @kaancfidan for applying the suggestions. I've recently taken over the maintenance of this project and I'm trying to wrap up all the outstanding PRs

[kaancfidan]

@ktrz although I have already applied the change; I have checked your suggested regex in regex101.com and it seems to cause problems there: https://regex101.com/r/kOwwOf/2

Could this be a sign that the suggested regex is too complex?

[ktrz]

@kaancfidan we didn't account for ( and ) characters. I've added a suggestion that resolves this

[kaancfidan]

@kaancfidan we didn't account for ( and ) characters. I've added a suggestion that resolves this

yep, it solves it: https://regex101.com/r/kOwwOf/3