Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH improve st in ADMM solver #9

Closed
tomMoral opened this issue May 6, 2022 · 2 comments
Closed

ENH improve st in ADMM solver #9

tomMoral opened this issue May 6, 2022 · 2 comments

Comments

@tomMoral
Copy link
Member

tomMoral commented May 6, 2022

The ADMM solver could be improved by removing the abs then sign in

benchmark_tv_1d/solvers/python-ADMM.py

Line 59 in d0a8a54

w -= np.sign(w) * abs(np.clip(w, -mu, mu))

@tomMoral tomMoral changed the title ENH ENH improve ST in ADMM solver May 6, 2022
@tomMoral tomMoral changed the title ENH improve ST in ADMM solver ENH improve st in ADMM solver May 6, 2022
@EnLAI111
Copy link
Collaborator

EnLAI111 commented May 9, 2022

It's done! I think that it should be just
w -= np.clip(w, -mu, mu)

@tomMoral
Copy link
Member Author

tomMoral commented May 9, 2022

Yes sorry, I wrote that too quick :)

@tomMoral tomMoral closed this as completed May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomMoral @EnLAI111