ENH - make get_next a regular solver method
#566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think it is worth going through a deprecation cycle for this as it is used extensively in benchmarks? Any thoughts @tomMoral @mathurinm? |
tomMoral
approved these changes
Jun 27, 2023
benchopt/tests/test_benchmarks/dummy_benchmark/solvers/solver_test.py
Outdated
Show resolved
Hide resolved
mathurinm
approved these changes
Jun 28, 2023
|
@Badr-MOUFAD can you add a whatsnew entry before we merge ? |
mathurinm
reviewed
Jun 28, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #566 +/- ##
==========================================
- Coverage 54.14% 54.09% -0.06%
==========================================
Files 43 43
Lines 2833 2834 +1
Branches 517 518 +1
==========================================
- Hits 1534 1533 -1
- Misses 1184 1185 +1
- Partials 115 116 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables accessing solvers parameters and attributes by making
get_nexta regular method instead ofstaticmethodcloses #564