Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH improve benchmark metadata handeling #621

Merged
merged 9 commits into from Aug 11, 2023

Conversation

tomMoral
Copy link
Member

On the result website, objective.py is not available to collect the benchmark metadata.
These metadata are stored in benchmark_meta.json which is created when using benchopt publish.

As only pretty_name is available for now, the reading of these data was manually done.
however, this is not very convenient in generate_html which handles both cases, when objective.py or benchmark_meta.json are available.
I propose to store all the metadata required by generate_html directly in the benchmark class and automatically retrieve them when objective.py is not available but benchmark_meta.json is.

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Merging #621 (d7818c4) into main (b7ec43e) will increase coverage by 0.15%.
The diff coverage is 15.25%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #621      +/-   ##
==========================================
+ Coverage   55.98%   56.14%   +0.15%     
==========================================
  Files          45       45              
  Lines        2890     2882       -8     
  Branches      528      530       +2     
==========================================
  Hits         1618     1618              
+ Misses       1154     1144      -10     
- Partials      118      120       +2     

@tomMoral tomMoral changed the title ENH simplify benchmark metadata handeling ENH improve benchmark metadata handeling Aug 11, 2023
@tomMoral tomMoral merged commit 9955d4c into benchopt:main Aug 11, 2023
15 checks passed
@tomMoral tomMoral deleted the ENH_benchmark_metadata branch August 11, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants