ENH improve benchmark metadata handeling #621
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the result website,
objective.py
is not available to collect the benchmark metadata.These metadata are stored in
benchmark_meta.json
which is created when usingbenchopt publish
.As only
pretty_name
is available for now, the reading of these data was manually done.however, this is not very convenient in
generate_html
which handles both cases, whenobjective.py
orbenchmark_meta.json
are available.I propose to store all the metadata required by
generate_html
directly in the benchmark class and automatically retrieve them whenobjective.py
is not available butbenchmark_meta.json
is.