Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX abstract classes in BaseObjective #631

Merged
merged 14 commits into from Jul 21, 2023

Conversation

tomMoral
Copy link
Member

This fixes the fact that BaseObjective was not raising error if an abstractmethod is not implemented.
It also makes the backward compatibility between compute/evaluate_result work with results that are dictionaries.

Finally, it renames Objective.get_one_solution into Objective.get_one_result.

doc/whats_new.rst Outdated Show resolved Hide resolved
Co-authored-by: mathurinm <mathurinm@users.noreply.github.com>
benchopt/base.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #631 (1cb0b2c) into main (c689d24) will increase coverage by 0.64%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
+ Coverage   55.08%   55.73%   +0.64%     
==========================================
  Files          44       44              
  Lines        2861     2869       +8     
  Branches      527      528       +1     
==========================================
+ Hits         1576     1599      +23     
+ Misses       1167     1153      -14     
+ Partials      118      117       -1     

@tomMoral tomMoral merged commit 07793b6 into benchopt:main Jul 21, 2023
15 checks passed
@tomMoral tomMoral deleted the FIX_result_solution_transition branch July 21, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants