New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX abstract classes in BaseObjective #631
Merged
tomMoral
merged 14 commits into
benchopt:main
from
tomMoral:FIX_result_solution_transition
Jul 21, 2023
Merged
FIX abstract classes in BaseObjective #631
tomMoral
merged 14 commits into
benchopt:main
from
tomMoral:FIX_result_solution_transition
Jul 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathurinm
reviewed
Jul 21, 2023
Co-authored-by: mathurinm <mathurinm@users.noreply.github.com>
mathurinm
reviewed
Jul 21, 2023
Co-authored-by: mathurinm <mathurinm@users.noreply.github.com>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #631 +/- ##
==========================================
+ Coverage 55.08% 55.73% +0.64%
==========================================
Files 44 44
Lines 2861 2869 +8
Branches 527 528 +1
==========================================
+ Hits 1576 1599 +23
+ Misses 1167 1153 -14
+ Partials 118 117 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the fact that
BaseObjective
was not raising error if an abstractmethod is not implemented.It also makes the backward compatibility between
compute/evaluate_result
work with results that are dictionaries.Finally, it renames
Objective.get_one_solution
intoObjective.get_one_result
.