Pr to upstream #165
Merged
Pr to upstream #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deps: security updates, some test fixes
This reverts commit a310120.
bencoveney
reviewed
Sep 24, 2021
src/index.test.ts
Outdated
| args.include, | ||
| args.exclude | ||
| ) | ||
| buildBarrelsSpy.calledOnceWithExactly( |
There was a problem hiding this comment.
Not suggesting it needs changing in this PR - but it looks like the assert here has been removed, but retained earlier up on similar lines (line 90 for example)
There was a problem hiding this comment.
good catch.. fixed it
bencoveney
reviewed
Sep 24, 2021
| @@ -0,0 +1,31 @@ | |||
| # This workflow will do a clean install of node dependencies, cache/restore them, build the source code and run tests across different versions of node | |||
There was a problem hiding this comment.
Should I disable CircleCI with this in place?
There was a problem hiding this comment.
Yeah, I'd say that's fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.