feat: add command line option for choosing between double and single quotes #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencoveney
reviewed
Oct 7, 2017
| .version() | ||
| .alias("v", "version") | ||
| .default("v", false) | ||
|
|
||
| .boolean("V") | ||
| .alias("V", "verbose") | ||
| .describe("V", "Display additional logging information") | ||
| .default("D", false); | ||
| .default("V", false); | ||
| } | ||
|
|
||
| export function getOptions(): Options { |
There was a problem hiding this comment.
Seeing as the quote character is going to be constant throughout execution of the program, you can evaluate it once here and add it to the options object rather than resolving it each time using getQuoteCharacter.
src/builders/flat.ts
Outdated
|
|
||
| import {buildImportPath} from "../builder"; | ||
|
|
||
| export function buildFlatBarrel(directory: Directory, modules: Location[], options: Options): string { | ||
| const quoteChar = getQuoteCharacter(options); |
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "barrelsby", | |||
| "version": "0.0.4", | |||
There was a problem hiding this comment.
Don't need to resolve this (as I can do it when I release) but there is already a v0.0.5 I released a beta for #34 so this will be released as v0.0.6.
|
Thank you for reviewing so quickly! I refactored so that we're using a |
|
Thanks 👍 Published to NPM as version 0.0.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people prefer single quotes for their imports. This PR add the -q option to use single quotes in the generated imports/exports.