Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding more entity objects #28

Closed
wants to merge 1 commit into from
Closed

Allow adding more entity objects #28

wants to merge 1 commit into from

Conversation

CristianHenzel
Copy link

No description provided.

@benct
Copy link
Owner

benct commented Jan 20, 2020

Thank you for your contribution! I want to add support for more entities (although there really aren't much room for more than 3 or maybe 4 in an entity row), but I have been planning on replacing the primary, secondary, etc configuration with something more dynamic like a list. So I won't merge this in just at the moment, as it will just make the current config more complex to convert.

@benct benct closed this Jan 20, 2020
@CristianHenzel
Copy link
Author

I just want to add that I could fairly easily add about 6-7 objects in a row with my config, so when you add the possibility to add more, if there will be a limit, please take into consideration that some people might want to use a couple more (I think about 5-6 should be a decent limit). Thank you! :-)

Screenshot 2020-01-20 at 15 22 04

@benct
Copy link
Owner

benct commented Jan 20, 2020

You're right, I did not think about the icon option :) The reason I want to convert it to a list instead of named objects is so that you could add as many entities as you want to. For your example above, It would be something like:

type: custom:multiple-entity-row
entity: light.ceiling
name: Ceiling
entities:
  - icon: mdi:light-on
    service: light.turn_on
  - icon: mdi:light-off
    service: light.turn_off
  - icon: mdi:light-something
    service: light.some_service
  - icon: mdi:something
    service: light.some_service
  - icon: mdi:something
    service: light.some_service

benct added a commit that referenced this pull request Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants