The changes proposed by Jan Benda have been edited #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 13, 2016 09:51
… peakdetection modul
…alysis) the funcion is included in the main fundtion as plot_data_func. Furthermore the loops now work with range() instead of np.arange()
…ment for fresolution. Furthermore the dcumentation has been edited.
added 2 commits
June 20, 2016 13:14
…tead of lists). Furthermore the extract_fundamentals function now can extract the fundamentals from single fishlists or multiple fishlists in a list. The documentation has also been edited.
| if np.sum(np.abs(fundamentals[list] - fundamental) < df_th) > 0: | ||
| consistency_help[enu] += 1 | ||
|
|
||
| index = np.arange(len(fundamentals[0]))[consistency_help == len(fundamentals)] |
There was a problem hiding this comment.
I think this is what the numpy.nonzero function does
There was a problem hiding this comment.
No. numpy.nonzero gives back the indices where the array is not zero. Here we are looking for the indices where value is the same as the number of given fishlists.
added 6 commits
June 21, 2016 11:08
…he threshold also used by Juan in the ckeckfishtype modul. Furthermore some code parts have been made smoother. Documentaion has also been edited.
…tentfishes modul to the harmoni groups modul.
…ndamental_freqs function has been movved there.
… the noverlap for the numpy.psd function is calculated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed some for loops that have not been necessary. Furthermore the plot functions had been removed from the main functions of the modules in several cases. And the loops now work with range() instead of np.arange() for better performance.