different methods are now available for setting bestwindow threshold. COMPLETE FOLDER WAS REFORMATED! #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fore merging new branch from Till.
…ntile or min-max approach. Default values of parameters were chosen using eye-precision.
| @@ -5,11 +5,11 @@ | |||
| import wave | |||
| import matplotlib.pyplot as plt | |||
| import sys | |||
| #import seaborn as sns | |||
| # import seaborn as sns | |||
There was a problem hiding this comment.
remove seaborn! Everywhere!
…ion was embeded as a parameter in function best_window_indices (from bestwindow.py). Code tested and working as far as I could recall.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore the reformat, this was basically for making things "einheitlich". important changes were performed in bestwindow.py and peakdetection.py. For setting the peakdetection threshold there are now three different approaches available: std, percentile and min-max. These are now included into peakdetection.py
peace out!