fixed python3 import pathes #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillraab
reviewed
Oct 10, 2016
| import dataloader as dl | ||
| import config_tools as ct | ||
| from dataloader import load_data | ||
| from config_tools import get_config_dict |
There was a problem hiding this comment.
why not "from .config_tools import get_config_dict" in this case ?
is the dot not required here ? and if so, why ?
jfsehuanes
reviewed
Oct 19, 2016
| upper = bins[inx][-1] # needs to return the next bin | ||
| hist, bins = np.histogram(data, nbins, density=True) | ||
| inx = hist > np.max(hist) * hist_height | ||
| lower = bins[0:-1][inx][0] |
There was a problem hiding this comment.
Nice. this finally gets rid of the stupid warning message!
jfsehuanes
reviewed
Oct 19, 2016
| import thunderfish.powerspectrum as ps | ||
| import thunderfish.harmonicgroups as hg | ||
| import thunderfish.config_tools as ct | ||
| from IPython import embed |
There was a problem hiding this comment.
hehe! I also always forget to remove it before pushing XD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the import pathes to make thunderfish running with python3 and python 2.7.
Important:
Install the likewise updated audioio package.
Run the modules for testing, as well as thunderfish and fishfinder as a package from the root directory of this package:
python -m thunderfish.thunderfish data.wav
python -m thunderfish.peakdetection
Calling them the usual way with "python thunderfish.py data.wav" will NOT work anymore. Ask google for "relative imports" to get an idea why...
In addition I added entrypoints to the setup.py. After you install thunderfish with
sudo python setup.py install
you can use thunderfish and fishfinder from any directory by simply calling
thunderfish somedata.wav
fishfinder cooldata.mp3
from your console.