fix(update): Delete old files on exit

babblebot-server · Mar 30, 2020 · 5353e39 · 5353e39
1 parent 533f06a
commit 5353e39
Showing 1 changed file with 15 additions and 9 deletions.
diff --git a/core/src/main/java/uk/co/bjdavies/core/UpdateService.java b/core/src/main/java/uk/co/bjdavies/core/UpdateService.java
@@ -8,6 +8,9 @@
 
 import java.io.*;
 import java.net.URL;
+import java.util.Arrays;
+import java.util.Objects;
+import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.zip.ZipEntry;
 import java.util.zip.ZipInputStream;
 
@@ -103,6 +106,7 @@ private boolean swapScripts(File unZipTmp) throws IOException {
     private boolean swapLibs(File unZipTmp) {
         File libsFolder = new File(unZipTmp + File.separator + "lib/");
         File ourLibsFolder = new File("../lib/");
+        log.info(ourLibsFolder.getAbsolutePath());
 
         if (!ourLibsFolder.exists()) {
             if (!ourLibsFolder.mkdirs()) {
@@ -117,22 +121,24 @@ private boolean swapLibs(File unZipTmp) {
                 return false;
             }
         }
-
-        if (ourLibsFolder.delete()) {
-            if (ourLibsFolder.mkdirs()) {
+        AtomicBoolean copy = new AtomicBoolean(true);
+        try {
+            Arrays.stream(Objects.requireNonNull(ourLibsFolder.listFiles())).forEach(File::deleteOnExit);
+            Arrays.stream(Objects.requireNonNull(libsFolder.listFiles())).forEach(f -> {
                 try {
-                    FileUtils.copyDirectory(libsFolder, ourLibsFolder, true);
+                    FileUtils.copyFileToDirectory(f, ourLibsFolder);
                 } catch (IOException e) {
                     log.error("Cant copy", e);
-                    return false;
+                    copy.set(false);
                 }
-            } else {
-                return false;
-            }
+            });
+        } catch (NullPointerException e) {
+            log.error("Cant copy", e);
+            return false;
         }
 
 
-        return true;
+        return copy.get();
     }
 
     private void extractFile(ZipInputStream zipIn, String filePath) throws IOException {