better checking mac and global regex for userAgent #7
Conversation
better checking mac and global regex for userAgent
There was a problem hiding this comment.
Based on what was submitted, I have to assume this is just changing things for the sake of it, in which case I'm not inclined to accept it.
If this is fixing a bug, add appropriate test coverage and then we can discuss the implementation.
I'm adding tests back for PRs, note that these changes break the tests.
| @@ -3,5 +3,5 @@ | |||
| var navigator = require('global/window').navigator | |||
|
|
|||
| module.exports = typeof navigator !== 'undefined' && | |||
There was a problem hiding this comment.
The regular expression is flagged as case insensitive (/i). Fine with lowercasing the input to avoid the need for a flag but it should be one or the other.
There was a problem hiding this comment.
Note the use of global/window to access navigator, which is then used in tests. Replacing this with window is not correct.
|
Closing due to non-response, feel free to address my comments and pick this back up at any time if you'd like. |
better checking mac and global regex for userAgent