Fix generic #41
Merged
Fix generic #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a failing test case that passes with your changes? I don't write TypeScript and rely on test coverage for details like this. |
|
Sure! Can you enable the tests for branches as well? So I can see whether they pass here? |
|
Oh and re: writing new tests, it seems like the tests are actually wrong, so I will just fix them :) |
|
One thing that I would like to do (just as a fun project) is to add proper recursive types using the new Template Literal Types in TypeScript 4.1.2. There is a microsoft/TypeScript#40336 (comment) So then TypeScript would know exactly what properties are on the final object. |
|
@bendrucker tests and types are fixed (in |
|
Great work, thank you! |
|
Glad to help, thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes implementation of #31