Numerical instability of NNSED

[HushTheBlock]

When I implemented NNSED on my own network, I encountered the following problem:

C:\Users\Administrator\anaconda3\lib\site-packages\karateclub\community_detection\overlapping\nnsed.py:75: RuntimeWarning: invalid value encountered in true_divide
self._W = self._W*(enum/denom)

and this is caused by some zero entries in denom.
After adding the following codes, my issues are resolved successfully, and NNSED can now converge.

def _update_W(self, A):
        enum = A.dot(self._Z.T)
        denom_1 = self._W.dot(self._Z).dot(self._Z.T)
        denom_2 = (A.dot(A.transpose())).dot(self._W)
        denom = denom_1 + denom_2 + **1e-6**
        self._W = self._W*(enum/denom)

def _update_Z(self, A):
        enum = (A.dot(self._W)).transpose()
        denom = np.dot(np.dot(self._W.T, self._W), self._Z) + self._Z + **1e-6**
        self._Z = self._Z*(enum/denom)

I hope this could be fixed in the next version.

[benedekrozemberczki]

Could you open a PR?

…

On Thu, 5 Nov 2020 at 11:51, Kwan ***@***.***> wrote: When I implemented NNSED on my own network, I encountered the following problem: C:\Users\Administrator\anaconda3\lib\site-packages\karateclub\community_detection\overlapping\nnsed.py:75: RuntimeWarning: invalid value encountered in true_divide self._W = self._W*(enum/denom) and this is caused by some zero entries in *denom*. After adding the following codes, my issues are resolved successfully, and NNSED can now converge. def _update_W(self, A): enum = A.dot(self._Z.T) denom_1 = self._W.dot(self._Z).dot(self._Z.T) denom_2 = (A.dot(A.transpose())).dot(self._W) denom = denom_1 + denom_2 + **1e-6** self._W = self._W*(enum/denom) def _update_Z(self, A): enum = (A.dot(self._W)).transpose() denom = np.dot(np.dot(self._W.T, self._W), self._Z) + self._Z + **1e-6** self._Z = self._Z*(enum/denom) I hope this could be fixed in the next version. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#56>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEETMFZO6RKAIVJYSWEZBYLSOKGV3ANCNFSM4TLIMJ7A> .

[benedekrozemberczki]

Fixed it.

[HushTheBlock]

Sure thing. But I'm new to github so you may need to wait a while.

Ahh sry. I noticed that you fixed the problem. Haha