Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed lambda_max error when normalization != sym #150

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

gravins
Copy link
Contributor

@gravins gravins commented Mar 31, 2022

gc_lstm, gconv_gru, and gconv_lstm throw an error when normalization is different from "sym". That is due to the fact that ChebConv requires lambda_max values for non-symmetric normalization.

@benedekrozemberczki
Copy link
Owner

Started the CI/CD, you can push and commit again and see whether it runs.

@codecov-commenter
Copy link

Codecov Report

Merging #150 (1a8826f) into master (88480db) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files          57       57           
  Lines        4996     4996           
=======================================
  Hits         4962     4962           
  Misses         34       34           
Impacted Files Coverage Δ
torch_geometric_temporal/nn/recurrent/gc_lstm.py 100.00% <100.00%> (ø)
torch_geometric_temporal/nn/recurrent/gconv_gru.py 100.00% <100.00%> (ø)
...orch_geometric_temporal/nn/recurrent/gconv_lstm.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88480db...1a8826f. Read the comment docs.

@benedekrozemberczki benedekrozemberczki merged commit c6d2aa9 into benedekrozemberczki:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants