Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change on _set_hidden_state() #187

Merged
merged 2 commits into from
Sep 4, 2022

Conversation

h3dema
Copy link
Contributor

@h3dema h3dema commented Aug 29, 2022

Allows TGCN2 to work with batch from different sizes. Current implementation forces all batches to be the same size (defined by self.batch_size).

Allows TGCN2 to work with batch from different sizes. Current implementation forces all batches to be the same size (defined by self.batch_size).
Copy link
Contributor Author

@h3dema h3dema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must keep the parameter for backward compatibility

@codecov-commenter
Copy link

Codecov Report

Merging #187 (cbb8ba5) into master (f76e06f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #187   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files          57       57           
  Lines        4989     4989           
=======================================
  Hits         4955     4955           
  Misses         34       34           
Impacted Files Coverage Δ
...rch_geometric_temporal/nn/recurrent/temporalgcn.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@benedekrozemberczki benedekrozemberczki merged commit 9d4a7ad into benedekrozemberczki:master Sep 4, 2022
@jamesmyatt
Copy link
Contributor

Documentation for A3TGCN2 also needs updating to indicate that batch_size is unused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants