-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PySam error with MarginAlign+Minimap2 (last realease) #46
Comments
Hi Felix, Couple of thoughts.
If you could share a toy dataset as an MWE for me to reproduce this here, that would be very helpful. Thank you. |
Hi Miten, Thanks for your very quick answer.
Concerning the MWE you asked for:
Thanks again. |
Hello,
I am trying to use MarginAlign with the last release of Minimap2 (
2.15-r908-dirty
) and I had several issues:I did the following sequence of commands to install MarginAlign and get the last release of Minimap2:
Everything went fine, both on the
make test
and using a toy dataset (20 reads against a small database).But when I used a bigger fastq file (against the same database) an error appeared, apparently coming from the
getLastNonClippedPositionInRead
function (utils.py
file). ThealignedSegment.query_alignment_end
was crashing and returning a "SystemError: error return without exception set" (I checked the 2 other variables, they seemed fine).I found a PySam issue mentionning a similar thing, but in a different context (pysam-developers/pysam#176), so I fixed this by installing
pysam==0.9.0
instead of the version mentionned in the requirement.txtI don't know, maybe I did something wrong, or maybe it is linked with the use of the last version of Minimap2 ?
--em
option, to run the EM learning followed by the realignement, I realized that MarginAlign was always loading the HMM file "last_hmm_20.txt". So I had to comment the lineoptions.inputModel = os.path.join(pathToBaseNanoporeDir(), "src", "margin", "mappers", "last_hmm_20.txt")
in themarginAlign.py
file.I guess this is linked with the fact that LAST is set as the default aligner, but maybe there is something to fix here?
Thanks in advance for your answer and many thanks for implementing Minimap2 into MarginAlign!
Felix.
The text was updated successfully, but these errors were encountered: