Rename parent_ids to ancestor_ids #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Nathan, thanks a lot for this pull requests. You're right about the naming and your changed absolutely make sense. With mongoid 5.0 coming up soon, I'll merge it with the next major release of mongoid-tree. Cheers, Benedikt |
|
Closing this PR; I haven't used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
parent_idsis confusingly named, because it actually contains the ids of the document's ancestors, not just parents. Since mongoid-tree only supports trees (not DAGs) it only makes sense for it to be a list of ancestors, but at a first glance the naming makes the code more confusing than necessary. I definitely understand if you don't want to change the API for something this trivial, but I thought I'd send a PR your way anyway in case you do think the change is worth it.