Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username in register() method should not be required #415

Closed
Andreyco opened this issue Mar 2, 2013 · 3 comments
Closed

Username in register() method should not be required #415

Andreyco opened this issue Mar 2, 2013 · 3 comments

Comments

@Andreyco
Copy link

Andreyco commented Mar 2, 2013

I have a problem/don't like current register() method

Register (create) a new user.

Parameters
'Username' - string REQUIRED.
'Password' - string REQUIRED.
'Email' - string REQUIRED.
'Additional Data' - multidimensional array REQUIRED.
'Group' - array OPTIONAL. If not passed the default group name set in the config will be used.

I do not agree username should be required and passed as 1st parameter. Username can be retrieved as join of first_name & last_name. Plus, in many cases, username is not realy needed, since this can be replaced with email.

What is you opinion on this (at least for me) issue?

@benedmunds
Copy link
Owner

I actually agree with you but have chosen to keep the API this way for backwards compatibility. In hindsight this really should have been changed with the 2.0 release. It's too late now though :/

@benedmunds
Copy link
Owner

A easy fix for this is to just pass the concat first/last name or the email as the username and ignore from then on.

@Andreyco
Copy link
Author

Andreyco commented Mar 3, 2013

Yeah, got your point... No problem here then.
Wonderful library anyway! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants