Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix import issue with newer versions of pybullet #49

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

isacarnekvist
Copy link
Contributor

Remaining issue that was partly fixed:
Issue: #36
Partal fix: #35

I just made the same one-liner fix for the mujoco envs. Tried it with pybullet 2.7.9 and it works.

Tests

Very little manual testing done, just opened an environment that previously did not work --- now it works.

Also ran:

python pybulletgym/tests/test_pybulletgym_mujoco_sanity.py

which reported no problems.

On the other hand:

python pybulletgym/tests/test_pybulletgym_roboschool_performance.py

showed this (before fix also):

The following envs perform worse: ['Walker2DPyBulletEnv-v0', 'HumanoidFlagrunHarderPyBulletEnv-v0', 'AtlasPyBulletEnv-v0'] 

The following envs have problems: ['PusherPyBulletEnv-v0', 'ThrowerPyBulletEnv-v0', 'StrikerPyBulletEnv-v0']

@benelot
Copy link
Owner

benelot commented Mar 29, 2021

The tests show that everything runs as expected. I tried to build a performance related test with roboschool performance, but that should not change with your import. No idea why it did not work as expected.

@benelot
Copy link
Owner

benelot commented Mar 29, 2021

I will merge as it its the correct fix to apply.

@benelot benelot merged commit 925c8d7 into benelot:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants