git: differentiate between no such branch and no such repo #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -166,6 +166,9 @@ def _get_commithash(self, remote, ref): | |||
| """ | |||
| ret_code, info, _ = self.manager.popen.run( | |||
| "git", "ls-remote", "--exit-code", remote, ref) | |||
| if ret_code == 128: | |||
| # repo not found | |||
There was a problem hiding this comment.
Thanks for this 👍, nice change in principle.
I can't find any docs on 128 for ls-remote - the exit code documentation for Git appears to me to be a bit light.
2 is mentioned as = "no matching refs are found" . We could consider changing it to != 2?
There was a problem hiding this comment.
Good point, !=2 should be safer.
(done)
oliver-sanders
commented
Jun 17, 2024
benfitzpatrick
approved these changes
Jun 18, 2024
benfitzpatrick
merged commit ec5e917
into
benfitzpatrick:1419.git_file_creation_loc_handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.