Implement functionality for book loans with updated readme.md #29
Conversation
- Redirect to login page on successful signup - Implemented Auth Failure to assign state
- Message display if no books exist
- Eslint plugin re-installed to fix hound issues
- Images uploaded to cloudinary on onChange Modal function - Db retieved from cloudinary ready to be used in the onClick method - ProgressBar changed to use props - ImageReducer implemented and added to rootReducer
- Updated the Readme.md file - Implemented a Display Modal for loaning a book - Implemented a pure component for the progress bar - Implemented an axios call for the loan book - Implement an Upload Image functionality
- Added sass linting to the repository chore (updates to read.md)
- New lint style for sass configured
| category={book.category} | ||
| description={book.description} | ||
| quantity={book.quantity} | ||
| image={book.bookimage} |
There was a problem hiding this comment.
Trailing spaces not allowed no-trailing-spaces
| description={book.description} | ||
| image={book.bookimage}/>); | ||
| }); | ||
| .map(book => (<Book |
There was a problem hiding this comment.
'books.map' is missing in props validation react/prop-types
| } | ||
|
|
There was a problem hiding this comment.
Trailing spaces not allowed no-trailing-spaces
| @@ -30,49 +35,44 @@ class DisplayLandingBooks extends React.Component{ | |||
| componentDidMount() { | |||
| this | |||
| .props | |||
| .fetchBooksforDashboard(this.state.offset, this.state.limit) | |||
| .fetchBooksforDashboard(this.state.offset, this.state.limit); | |||
There was a problem hiding this comment.
'fetchBooksforDashboard' is missing in props validation react/prop-types
| import { PropTypes } from 'prop-types'; | ||
| import { Preloader } from 'react-materialize'; | ||
| import Book from '../../presentation/common/book/DisplayBook.jsx'; | ||
| import { fetchBooksforDashboard } from '../../../actions/fetchbooks'; |
There was a problem hiding this comment.
Unable to resolve path to module '../../../actions/fetchbooks' import/no-unresolved
Missing file extension for "../../../actions/fetchbooks" import/extensions
| {...rest} | ||
| render={props => (isAuthenticated && tokenExists | ||
| ? <Component{...props}/> | ||
| : <Redirect to='/login'/>)} |
There was a problem hiding this comment.
Unexpected usage of singlequote jsx-quotes
A space is required before closing bracket react/jsx-tag-spacing
Trailing spaces not allowed no-trailing-spaces
| <Route | ||
| {...rest} | ||
| render={props => (isAuthenticated && tokenExists | ||
| ? <Component{...props}/> |
There was a problem hiding this comment.
A space is required before closing bracket react/jsx-tag-spacing
| }) => ( | ||
| <Route | ||
| {...rest} | ||
| render={props => (isAuthenticated && tokenExists |
There was a problem hiding this comment.
Expected indentation of 4 space characters but found 6 react/jsx-indent-props
| ...rest | ||
| }) => ( | ||
| <Route | ||
| {...rest} |
There was a problem hiding this comment.
Expected indentation of 4 space characters but found 6 react/jsx-indent-props
| const UserRoutes = ({ | ||
| isAuthenticated, | ||
| tokenExists, | ||
| component: Component, |
There was a problem hiding this comment.
'Component' is already declared in the upper scope no-shadow
benfluleck
deleted the
feature/152838221/implement-functionality-for-book-loans-with-updated-Readme.md
branch
This PR implements the feedback from my code review.
This PR implements the book loan functionality, upload images to cloudinary
Description
Screenshots (if appropriate):
Any background context you want to provide?
What are the relevant pivotal tracker stories?
https://www.pivotaltracker.com/story/show/152838944
Types of changes
Checklist: