Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of return book functionality #30

Conversation

benfluleck
Copy link
Owner

Description

Return book functionality added to the project. With the aid of a button in the modal form authenticated users can return books.

What does this PR do?

Description of Task to be completed?

Screenshots (if appropriate):

Any background context you want to provide?

What are the relevant pivotal tracker stories?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@@ -174,7 +174,7 @@ form p {
}
}

/**
/*

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use // comments everywhere

@@ -76,7 +76,7 @@ form p {
.root-wrapper {
min-height: 100%;
display: flex;
min-height: 100vh;
min-height: 95vh;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented with spaces, not tabs
Property min-height already defined on line 77

...state,
returnedbooks:{},
error: action
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon semi

{
return {
...state,
returnedbooks:{},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space before value for key 'returnedbooks' key-spacing

return {
...state,
returnedbooks: action
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon semi

.then((response)=>{
const message = response.message;
dispatch(showSuccessNotification({message}))
dispatch(ReturnBookSuccess(response))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected indentation of 4 spaces but found 2 indent
Missing semicolon semi

.returnbook(data)
.then((response)=>{
const message = response.message;
dispatch(showSuccessNotification({message}))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected indentation of 4 spaces but found 2 indent
A space is required after '{' object-curly-spacing
A space is required before '}' object-curly-spacing
Missing semicolon semi

.book
.returnbook(data)
.then((response)=>{
const message = response.message;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected indentation of 4 spaces but found 2 indent
Trailing spaces not allowed no-trailing-spaces

export const returnbook = data => dispatch => api
.book
.returnbook(data)
.then((response)=>{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected indentation of 2 spaces but found 0 indent
Missing space before => arrow-spacing
Missing space after => arrow-spacing

*/
export const returnbook = data => dispatch => api
.book
.returnbook(data)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected indentation of 2 spaces but found 0 indent

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.526% when pulling ea42d72 on feature/152996515/implement-functionality-for-book-return into 2ffdc2b on development.

@benfluleck benfluleck merged commit 2707f66 into development Nov 20, 2017
@benfluleck benfluleck deleted the feature/152996515/implement-functionality-for-book-return branch November 20, 2017 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants