Feature/153009051/implement route to retrieve a user book history #32
Conversation
…the landing page fix(borrowedbooks logic): - Borrowed books logic removed from landing page
- Readme updated from previous feedback - Reducer logic refactored adopting proper naming conventions - Loan history feature implemented - Return book logic implemented - Modified pagination component to suit web app - Implemented loan history route [Finishes #152996631, #152996515, #152838221, #153009051]
| }; | ||
|
|
||
| const mapStateToProps = state => ({ | ||
| bookOperations : state.bookReducer.bookOperations |
There was a problem hiding this comment.
Extra space after key 'bookOperations' key-spacing
Trailing spaces not allowed no-trailing-spaces
| bookOperations: null | ||
| }; | ||
|
|
||
| const mapStateToProps = state => ({ |
There was a problem hiding this comment.
Trailing spaces not allowed no-trailing-spaces
|
|
||
|
|
||
| LoanHistory.defaultProps = { | ||
| bookOperations: null |
There was a problem hiding this comment.
Expected indentation of 2 spaces but found 3 indent
|
|
||
| LoanHistory.PropTypes = { | ||
| bookOperations: PropTypes.array | ||
|
|
There was a problem hiding this comment.
Trailing spaces not allowed no-trailing-spaces
| } | ||
|
|
||
|
|
||
| LoanHistory.PropTypes = { |
There was a problem hiding this comment.
Typo in static class property declaration react/no-typos
| const config = { items: pagination.pageCount, | ||
| activePage: pagination.page | ||
| }; | ||
| return( |
There was a problem hiding this comment.
Expected space(s) after "return" keyword-spacing
| const { pagination } = this.props.bookOperations; | ||
| const config = { items: pagination.pageCount, | ||
| activePage: pagination.page | ||
| }; |
There was a problem hiding this comment.
Expected indentation of 4 spaces but found 18 indent
| } | ||
| const { pagination } = this.props.bookOperations; | ||
| const config = { items: pagination.pageCount, | ||
| activePage: pagination.page |
There was a problem hiding this comment.
Expected indentation of 6 spaces but found 20 indent
| return <Preloader size="big" className="center-align" />; | ||
| } | ||
| const { pagination } = this.props.bookOperations; | ||
| const config = { items: pagination.pageCount, |
There was a problem hiding this comment.
Expected a line break after this opening brace object-curly-newline
Trailing spaces not allowed no-trailing-spaces
| if (!this.props.bookOperations) { | ||
| return <Preloader size="big" className="center-align" />; | ||
| } | ||
| const { pagination } = this.props.bookOperations; |
There was a problem hiding this comment.
'bookOperations.pagination' is missing in props validation react/prop-types
benfluleck
deleted the
feature/153009051/Implement-route-to-retrieve-a-user-book-history
branch
This PR implements Loan History, Loan and Return Book
Description
Loan history - A tab displays a table with information showing the users book loans and return history.
Loan book - The user clicks on a book and now has the option to Loan it.
Return book- Any books loaned can be returned by the user.
Screenshots (if appropriate):
Any background context you want to provide?
What are the relevant pivotal tracker stories?
Types of changes
Checklist: