User should be informed when books are overdue #33

benfluleck · 2017-11-24T17:10:27Z

Description

Users should be informed that books are overdue. This has been implemented through the client side and email notifications.

What does this PR do?

This PR implements changes to overdue books,
css styling changes to the UI
changes to loading of borrowed books
constructed an api route to borrow books
scheduler implemented to run daily to inform user of overdue books

Screenshots (if appropriate):

Any background context you want to provide?

Cron job

What are the relevant pivotal tracker stories?

https://www.pivotaltracker.com/story/show/153101662

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
New chore (expected functionality to be implemented)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.

- Eslint changes to the updated files

-Changes to the loading of the borrowed books

- api route constructed for overdue books - If the return date has passed then the user can retrieve a list of the books

- Users can now see books that thet have not returned on time - Users can return books from the Overdue books interface.

- Users are inform by email when they have overdue books with the title of the book. - Scheduler to send email daily to inform the user on their overdue books. [Delivers #153101662] - Changes to schedule fix (Clear cache): Cache cleared - DS_Store and vscode removed

houndci-bot · 2017-11-24T17:10:50Z

server/src/routes/index.js


-Router.get('/users/borrowedbooks', authdecodeToken, UserBooksController.getborrowedBooklist);
+Router.get('/users/getoverduebooks', authdecodeToken, UserBooksController.getOverdueBooks)


Missing semicolon semi

houndci-bot · 2017-11-24T17:10:50Z

server/src/mailer/mailer.js

+    bcc,
+    subject,
+    html,
+  });


Expected indentation of 0 spaces but found 2 indent

houndci-bot · 2017-11-24T17:10:51Z

server/src/mailer/mailer.js

+    to,
+    bcc,
+    subject,
+    html,


Expected indentation of 2 spaces but found 4 indent

houndci-bot · 2017-11-24T17:10:51Z

server/src/mailer/mailer.js

+    from: 'Mailer from library.com',
+    to,
+    bcc,
+    subject,


Expected indentation of 2 spaces but found 4 indent

houndci-bot · 2017-11-24T17:10:51Z

server/src/mailer/mailer.js

+  export const mailOptions = (to, bcc, subject, html) => ({
+    from: 'Mailer from library.com',
+    to,
+    bcc,


Expected indentation of 2 spaces but found 4 indent

houndci-bot · 2017-11-24T17:10:51Z

server/src/mailer/mailer.js

+    service: 'gmail',
+    auth: {
+      user: process.env.EMAIL_ADDRESS,
+      pass: process.env.EMAIL_PASSWORD


Expected indentation of 4 spaces but found 6 indent

houndci-bot · 2017-11-24T17:10:51Z

server/src/mailer/mailer.js

+  export const transporter = nodemailer.createTransport({
+    service: 'gmail',
+    auth: {
+      user: process.env.EMAIL_ADDRESS,


Expected indentation of 4 spaces but found 6 indent

houndci-bot · 2017-11-24T17:10:51Z

server/src/mailer/mailer.js

+
+  export const transporter = nodemailer.createTransport({
+    service: 'gmail',
+    auth: {


Expected indentation of 2 spaces but found 4 indent

houndci-bot · 2017-11-24T17:10:51Z

server/src/mailer/mailer.js

+  require('dotenv').config();
+
+  export const transporter = nodemailer.createTransport({
+    service: 'gmail',


Expected indentation of 2 spaces but found 4 indent

houndci-bot · 2017-11-24T17:10:51Z

server/src/mailer/mailer.js

+  import nodemailer from 'nodemailer';
+  require('dotenv').config();
+
+  export const transporter = nodemailer.createTransport({


Expected indentation of 0 spaces but found 2 indent

coveralls · 2017-11-24T17:13:43Z

Coverage decreased (-4.08%) to 86.572% when pulling 8d3078a on feature/152838944/user-should-be-informed-when-books-are-overdue into 7783e22 on development.

houndci-bot · 2017-11-24T17:43:10Z

client/src/app/components/container/booklist/DisplayBorrowedBooks.jsx

+        numberOfRecords={this.state.limit}
+        fetch={this.props.fetchAllBooksbyId}
+      />
+    </div>);


Expected closing tag to match indentation of opening react/jsx-closing-tag-location

houndci-bot · 2017-11-24T17:43:10Z

client/src/app/components/container/booklist/DisplayBorrowedBooks.jsx

-                         fetch={this.props.fetchAllBooksbyId}/>
-
-    </div>;
+


Trailing spaces not allowed no-trailing-spaces

houndci-bot · 2017-11-24T17:43:10Z

client/src/app/components/container/booklist/DisplayBorrowedBooks.jsx

-				/>
-      );
-    });
+    const getAllBooks = this.props.borrowedBooks.books.map(book => (


'borrowedBooks.books.map' is missing in props validation react/prop-types

houndci-bot · 2017-11-24T17:43:10Z

client/src/app/components/container/booklist/DisplayBorrowedBooks.jsx

-import  Book  from '../../presentation/common/book/DisplayBook.jsx';
+import { Preloader, Row, Col } from 'react-materialize';
+import PaginationWrapper from '../common/Pagination.jsx';
+import Book from '../../presentation/common/book/DisplayBook.jsx';


Unable to resolve path to module '../../presentation/common/book/DisplayBook.jsx' import/no-unresolved
Unexpected use of file extension "jsx" for "../../presentation/common/book/DisplayBook.jsx" import/extensions

houndci-bot · 2017-11-24T17:43:10Z

client/src/app/components/container/booklist/DisplayBorrowedBooks.jsx

-import PaginationWrapper from '../common/Pagination.jsx'
-import  Book  from '../../presentation/common/book/DisplayBook.jsx';
+import { Preloader, Row, Col } from 'react-materialize';
+import PaginationWrapper from '../common/Pagination.jsx';


Unexpected use of file extension "jsx" for "../common/Pagination.jsx" import/extensions
Unable to resolve path to module '../common/Pagination.jsx' import/no-unresolved

houndci-bot · 2017-11-24T17:43:11Z

client/src/app/components/container/booklist/DisplayOverdueBooks.jsx

+   * @returns {object} component
+   */
+  render() {
+    if (!this.props.overdueBooks || this.props.overdueBooks.books.length === 0) {


'overdueBooks' is missing in props validation react/prop-types
'overdueBooks.books' is missing in props validation react/prop-types
'overdueBooks.books.length' is missing in props validation react/prop-types

houndci-bot · 2017-11-24T17:43:11Z

client/src/app/components/container/booklist/DisplayOverdueBooks.jsx

+    <div className="pre-loader">
+      {this.state.isLoading && <Preloader size="big" />}
+    </div>;
+    this.props.fetchOverdueBookstoDashboard (this.state.offset, this.state.limit);


'fetchOverdueBookstoDashboard' is missing in props validation react/prop-types
Unexpected space between function name and paren no-spaced-func
Unexpected space between function name and paren func-call-spacing
Irregular whitespace not allowed no-irregular-whitespace

houndci-bot · 2017-11-24T17:43:11Z

client/src/app/components/container/booklist/DisplayOverdueBooks.jsx

+   * @returns {void}
+   */
+  componentDidMount() {
+    <div className="pre-loader">


Expected an assignment or function call and instead saw an expression no-unused-expressions

houndci-bot · 2017-11-24T17:43:11Z

client/src/app/components/container/booklist/DisplayOverdueBooks.jsx

+ * @extends {Component}
+ */
+class DisplayOverdueBooks extends React.Component {
+  constructor(props) {


Missing JSDoc comment require-jsdoc

houndci-bot · 2017-11-24T17:43:11Z

client/src/app/components/container/booklist/DisplayOverdueBooks.jsx

+import PaginationWrapper from '../common/Pagination.jsx';
+import Book from '../../presentation/common/book/DisplayBook.jsx';
+import { fetchOverdueBookstoDashboard } from '../../../actions/fetchbooks';
+import MessageforNoOverdueBooks from '../../presentation/messages/dashboardMessages/MessageforNoOverdueBooks.jsx';


Unexpected use of file extension "jsx" for "../../presentation/messages/dashboardMessages/MessageforNoOverdueBooks.jsx" import/extensions
Unable to resolve path to module '../../presentation/messages/dashboardMessages/MessageforNoOverdueBooks.jsx' import/no-unresolved

coveralls · 2017-11-24T17:45:41Z

Coverage decreased (-4.08%) to 86.572% when pulling 2bcd592 on feature/152838944/user-should-be-informed-when-books-are-overdue into 7783e22 on development.

fixed coverage score by implementing exclude bloack for nyc

houndci-bot · 2017-11-24T17:53:54Z

server/src/mailer/mailer.js

@@ -0,0 +1,14 @@
+import nodemailer from 'nodemailer';
+require('dotenv').config();


Unable to resolve path to module 'dotenv' import/no-unresolved

houndci-bot · 2017-11-24T17:53:54Z

server/src/mailer/mailer.js

@@ -0,0 +1,14 @@
+import nodemailer from 'nodemailer';


Expected empty line after import statement not followed by another import import/newline-after-import
Unable to resolve path to module 'nodemailer' import/no-unresolved
Missing file extension for "nodemailer" import/extensions

houndci-bot · 2017-11-24T17:53:54Z

server/src/cron/sendSurcharge.js

+.catch((error) => { 
+  process.stdout.write(error.stack);   
+  process.exit(0);
+})


Expected indentation of 2 spaces but found 0 indent

houndci-bot · 2017-11-24T17:53:54Z

server/src/cron/sendSurcharge.js

+})
+.catch((error) => { 
+  process.stdout.write(error.stack);   
+  process.exit(0);


Expected indentation of 4 spaces but found 2 indent

houndci-bot · 2017-11-24T17:53:54Z

server/src/cron/sendSurcharge.js

+  });  
+})
+.catch((error) => { 
+  process.stdout.write(error.stack);   


Expected indentation of 4 spaces but found 2 indent
Trailing spaces not allowed no-trailing-spaces

houndci-bot · 2017-11-24T17:53:55Z

server/src/cron/sendSurcharge.js

+  emails.forEach((email,index) => {
+    const to = email;
+    const bcc = null;
+    const subject = "Default on Returning Book";


Strings must use singlequote quotes

houndci-bot · 2017-11-24T17:53:55Z

server/src/cron/sendSurcharge.js

+    bookTitles.push(book.book.title);
+  });
+
+  emails.forEach((email,index) => {


A space is required after ',' comma-spacing

houndci-bot · 2017-11-24T17:53:55Z

server/src/cron/sendSurcharge.js

+  where: {
+    returnstatus: false,
+    returndate: {
+      $lt: Date.now() - 24 * 1000


Unexpected mix of '-' and '*' no-mixed-operators

houndci-bot · 2017-11-24T17:53:55Z

server/src/cron/sendSurcharge.js

@@ -0,0 +1,63 @@
+import moment from 'moment';
+import model from '../models';
+import { transporter, mailOptions } from '../mailer/mailer';


Unable to resolve path to module '../mailer/mailer' import/no-unresolved
Missing file extension for "../mailer/mailer" import/extensions

houndci-bot · 2017-11-24T17:53:55Z

server/src/cron/sendSurcharge.js

@@ -0,0 +1,63 @@
+import moment from 'moment';
+import model from '../models';


Unable to resolve path to module '../models' import/no-unresolved
Missing file extension for "../models" import/extensions

houndci-bot · 2017-11-24T17:53:56Z

server/src/mailer/mailer.js

@@ -0,0 +1,14 @@
+import nodemailer from 'nodemailer';
+require('dotenv').config();


Unable to resolve path to module 'dotenv' import/no-unresolved

houndci-bot · 2017-11-24T17:53:56Z

server/src/mailer/mailer.js

@@ -0,0 +1,14 @@
+import nodemailer from 'nodemailer';


Expected empty line after import statement not followed by another import import/newline-after-import
Unable to resolve path to module 'nodemailer' import/no-unresolved
Missing file extension for "nodemailer" import/extensions

houndci-bot · 2017-11-24T17:53:56Z

server/src/cron/sendSurcharge.js

+.catch((error) => { 
+  process.stdout.write(error.stack);   
+  process.exit(0);
+})


Expected indentation of 2 spaces but found 0 indent

houndci-bot · 2017-11-24T17:53:56Z

server/src/cron/sendSurcharge.js

+})
+.catch((error) => { 
+  process.stdout.write(error.stack);   
+  process.exit(0);


Expected indentation of 4 spaces but found 2 indent

houndci-bot · 2017-11-24T17:53:56Z

server/src/cron/sendSurcharge.js

+  });  
+})
+.catch((error) => { 
+  process.stdout.write(error.stack);   


Expected indentation of 4 spaces but found 2 indent
Trailing spaces not allowed no-trailing-spaces

houndci-bot · 2017-11-24T17:53:57Z

server/src/cron/sendSurcharge.js

+  emails.forEach((email,index) => {
+    const to = email;
+    const bcc = null;
+    const subject = "Default on Returning Book";


Strings must use singlequote quotes

houndci-bot · 2017-11-24T17:53:57Z

server/src/cron/sendSurcharge.js

+    bookTitles.push(book.book.title);
+  });
+
+  emails.forEach((email,index) => {


A space is required after ',' comma-spacing

houndci-bot · 2017-11-24T17:53:57Z

server/src/cron/sendSurcharge.js

+  where: {
+    returnstatus: false,
+    returndate: {
+      $lt: Date.now() - 24 * 1000


Unexpected mix of '-' and '*' no-mixed-operators

houndci-bot · 2017-11-24T17:53:57Z

server/src/cron/sendSurcharge.js

@@ -0,0 +1,63 @@
+import moment from 'moment';
+import model from '../models';
+import { transporter, mailOptions } from '../mailer/mailer';


Unable to resolve path to module '../mailer/mailer' import/no-unresolved
Missing file extension for "../mailer/mailer" import/extensions

houndci-bot · 2017-11-24T17:53:57Z

server/src/cron/sendSurcharge.js

@@ -0,0 +1,63 @@
+import moment from 'moment';
+import model from '../models';


Unable to resolve path to module '../models' import/no-unresolved
Missing file extension for "../models" import/extensions

coveralls · 2017-11-24T17:56:56Z

Coverage decreased (-1.8%) to 88.903% when pulling 0666589 on feature/152838944/user-should-be-informed-when-books-are-overdue into 7783e22 on development.

Benny Ogidan added 6 commits November 22, 2017 20:39

chore (es-lint refactoring):

d10c50d

- Eslint changes to the updated files

bug-fix (Heroku build):

6622ffc

-Changes to the loading of the borrowed books

feature (overdue books route):

6bfeae1

- api route constructed for overdue books - If the return date has passed then the user can retrieve a list of the books

feature (overdue books):

9a15755

- Users can now see books that thet have not returned on time - Users can return books from the Overdue books interface.

fix(bug): fix Travis error cron job pointing to dist

8d3078a

houndci-bot reviewed Nov 24, 2017

View reviewed changes

Benny Ogidan added 2 commits November 24, 2017 18:37

fix (coverage score): fixing coverage score

e72df56

fix (Hound issues): Fixed hound violations

2bcd592

houndci-bot reviewed Nov 24, 2017

View reviewed changes

fix-bug:(coverage score)

0666589

fixed coverage score by implementing exclude bloack for nyc

houndci-bot reviewed Nov 24, 2017

View reviewed changes

benfluleck merged commit 8bac566 into development Nov 24, 2017

benfluleck deleted the feature/152838944/user-should-be-informed-when-books-are-overdue branch December 13, 2017 12:37


		Router.get('/users/borrowedbooks', authdecodeToken, UserBooksController.getborrowedBooklist);
		Router.get('/users/getoverduebooks', authdecodeToken, UserBooksController.getOverdueBooks)

		@@ -0,0 +1,14 @@
		import nodemailer from 'nodemailer';
		require('dotenv').config();

		@@ -0,0 +1,63 @@
		import moment from 'moment';
		import model from '../models';

User should be informed when books are overdue #33

User should be informed when books are overdue #33

Conversation

benfluleck commented Nov 24, 2017

Description

What does this PR do?

Screenshots (if appropriate):

Any background context you want to provide?

What are the relevant pivotal tracker stories?

Types of changes

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Nov 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Nov 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Nov 24, 2017