Web app should be scheduled during downtime #34
Conversation
- wakeUpDyno implemented on server side to wake Heroku up for the surCharge
| } | ||
| }); | ||
| }).on('error', function(err) { | ||
| console.log("Error: " + err.message); |
There was a problem hiding this comment.
Expected indentation of 2 spaces but found 4 indent
Unexpected console statement no-console
Unexpected string concatenation prefer-template
Strings must use singlequote quotes
| console.log(err.message); | ||
| } | ||
| }); | ||
| }).on('error', function(err) { |
There was a problem hiding this comment.
Unexpected function expression prefer-arrow-callback
Unexpected unnamed function func-names
Missing space before function parentheses space-before-function-paren
| } catch (err) { | ||
| console.log(err.message); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Expected indentation of 2 spaces but found 4 indent
| console.log("======WAKUP DYNO: HEROKU RESPONSE: " + chunk); | ||
| } catch (err) { | ||
| console.log(err.message); | ||
| } |
There was a problem hiding this comment.
Expected indentation of 4 spaces but found 8 indent
| // optional logging... disable after it's working | ||
| console.log("======WAKUP DYNO: HEROKU RESPONSE: " + chunk); | ||
| } catch (err) { | ||
| console.log(err.message); |
There was a problem hiding this comment.
Expected indentation of 6 spaces but found 12 indent
Unexpected console statement no-console
| port: 80, | ||
| path: '/WAKEUP_DYNO' | ||
| }; | ||
| console.log("======WAKEUP DYNO START"); |
There was a problem hiding this comment.
Unexpected console statement no-console
Strings must use singlequote quotes
| const options = { | ||
| host: 'staging-hellobooks.herokuapp.com', | ||
| port: 80, | ||
| path: '/WAKEUP_DYNO' |
There was a problem hiding this comment.
Expected indentation of 2 spaces but found 4 indent
|
|
||
| const options = { | ||
| host: 'staging-hellobooks.herokuapp.com', | ||
| port: 80, |
There was a problem hiding this comment.
Expected indentation of 2 spaces but found 4 indent
| import http from 'http'; | ||
|
|
||
| const options = { | ||
| host: 'staging-hellobooks.herokuapp.com', |
There was a problem hiding this comment.
Expected indentation of 2 spaces but found 4 indent
| @@ -0,0 +1,20 @@ | |||
| import http from 'http'; | |||
There was a problem hiding this comment.
Trailing spaces not allowed no-trailing-spaces
benfluleck
deleted the
bug/153147800/web-app-should-be-scheduled-during-downtime
branch
Web app scheduled to be sent during down time.
Description
Overdue notifications are to be sent during downtime, during this time heroku puts the app to sleep.
The implements a scheduler to wake up the application once a day so it can send the mail.
What does this PR do?
The PR fixes the bug
Screenshots (if appropriate):
Any background context you want to provide?
Heroku Dynos
What are the relevant pivotal tracker stories?
Listed above
Types of changes
Checklist: