feature(search): Implement search feature app #37
Conversation
- Implemented search function for app utilising search books api - Implemented search component and strategy on reducer [Delivers #153149549]
| } | ||
|
|
||
| .react-autosuggest__container{ | ||
| padding-top: 5.5px; |
There was a problem hiding this comment.
Line should be indented with spaces, not tabs
| // margin-left: -6px; | ||
| } | ||
|
|
||
| .react-autosuggest__container{ |
There was a problem hiding this comment.
Selector react-autosuggest__container should be written in lowercase with hyphens
Opening curly brace { should be preceded by one space
|
|
||
| i.medium{ | ||
| font-size: 2.5rem ; | ||
| padding-top: 14px ; |
There was a problem hiding this comment.
Line should be indented with spaces, not tabs
Declaration should not have a space before the terminating semicolon
| } | ||
|
|
||
| i.medium{ | ||
| font-size: 2.5rem ; |
There was a problem hiding this comment.
Line should be indented with spaces, not tabs
Declaration should not have a space before the terminating semicolon
| height: 2.4rem !important; | ||
| } | ||
|
|
||
| i.medium{ |
There was a problem hiding this comment.
Avoid qualifying class selectors with an element.
Opening curly brace { should be preceded by one space
| @@ -1,18 +1,20 @@ | |||
| import React from 'react'; | |||
| import { Row } from 'react-materialize'; | |||
| import { Row, Icon, Col } from 'react-materialize'; | |||
There was a problem hiding this comment.
'Icon' is defined but never used no-unused-vars
'Col' is defined but never used no-unused-vars
Missing file extension for "react-materialize" import/extensions
Unable to resolve path to module 'react-materialize' import/no-unresolved
| @@ -5,6 +5,7 @@ import { Row, Preloader, Col } from 'react-materialize'; | |||
| import Book from '../../presentation/common/book/DisplayBook.jsx'; | |||
| import { fetchAllBooks } from '../../../actions/fetchbooks'; | |||
| import PaginationWrapper from '../common/Pagination.jsx'; | |||
| import SearchBooks from '../../presentation/common/book/SearchBooks.jsx'; | |||
There was a problem hiding this comment.
Unable to resolve path to module '../../presentation/common/book/SearchBooks.jsx' import/no-unresolved
Unexpected use of file extension "jsx" for "../../presentation/common/book/SearchBooks.jsx" import/extensions
| SEARCH_BOOKS_SUCCESS, | ||
| SEARCH_BOOKS_FAILURE | ||
| } from './actiontype'; | ||
| import api from './api'; |
There was a problem hiding this comment.
Unable to resolve path to module './api' import/no-unresolved
Missing file extension for "./api" import/extensions
| import { | ||
| SEARCH_BOOKS_SUCCESS, | ||
| SEARCH_BOOKS_FAILURE | ||
| } from './actiontype'; |
There was a problem hiding this comment.
Unable to resolve path to module './actiontype' import/no-unresolved
Missing file extension for "./actiontype" import/extensions
| @@ -0,0 +1,29 @@ | |||
| import { showErrorNotification } from './notifications'; | |||
There was a problem hiding this comment.
Unable to resolve path to module './notifications' import/no-unresolved
Missing file extension for "./notifications" import/extensions
|
Changes Unknown when pulling 953ea00 on chore/153149549/users-should-be-able-to-search-for-books into ** on development**. |
benfluleck
deleted the
chore/153149549/users-should-be-able-to-search-for-books
branch
Implementation of search functionality on the client side web app.
Description
What does this PR do?
Description of Task to be completed?
Screenshots (if appropriate):
Any background context you want to provide?
What are the relevant pivotal tracker stories?
https://www.pivotaltracker.com/story/show/153149549
Types of changes
Checklist: