Users can categorize all books #38

benfluleck · 2017-12-03T19:41:43Z

Users are able to categorize books

Description

Functionality developed for users to implement searches based on categorization.
Component for categorization developed for both large and small screens

Screenshots (if appropriate):

Any background context you want to provide?

What are the relevant pivotal tracker stories?

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
New chore (expected functionality to be implemented)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.

- Categorization of books implemented - List of categories of books implemented - Search functionality implemented

houndci-bot · 2017-12-03T19:42:05Z

client/src/app/components/presentation/messages/dashboardMessages/MessageforNoCatBooks.jsx

@@ -0,0 +1,15 @@
+import React from 'react';
+import { Row } from 'react-materialize';


Unable to resolve path to module 'react-materialize' import/no-unresolved
Missing file extension for "react-materialize" import/extensions

houndci-bot · 2017-12-03T19:42:05Z

client/src/app/components/presentation/messages/dashboardMessages/MessageforNoCatBooks.jsx

@@ -0,0 +1,15 @@
+import React from 'react';


Unable to resolve path to module 'react' import/no-unresolved
Missing file extension for "react" import/extensions

houndci-bot · 2017-12-03T19:42:05Z

client/src/app/css/style.scss

+}
+
+.category-hr {
+	margin-top: -1px;


Line should be indented with spaces, not tabs

houndci-bot · 2017-12-03T19:42:05Z

client/src/app/css/style.scss

+
+.category-name:hover {
+	background-color: $base-light-orange;
+


Line contains trailing whitespace

houndci-bot · 2017-12-03T19:42:05Z

client/src/app/css/style.scss

+}
+
+.category-name:hover {
+	background-color: $base-light-orange;


Line should be indented with spaces, not tabs

houndci-bot · 2017-12-03T19:42:06Z

client/src/app/css/style.scss

+
+.category-name {
+	padding-left: 45px !important;
+	color: #000000 !important;


Line should be indented with spaces, not tabs
!important should not be used
Color literals like #000000 should only be used in variable declarations; they should be referred to via variable everywhere else.

houndci-bot · 2017-12-03T19:42:06Z

client/src/app/css/style.scss

+}
+
+.category-name {
+	padding-left: 45px !important;


Line should be indented with spaces, not tabs
!important should not be used
Properties should be ordered color, padding-left

houndci-bot · 2017-12-03T19:42:06Z

client/src/app/css/style.scss

+
+.collapsible-header {
+	padding-left: 32px !important;
+	color: $base-white;


Line should be indented with spaces, not tabs

houndci-bot · 2017-12-03T19:42:06Z

client/src/app/css/style.scss

+}
+
+.collapsible-header {
+	padding-left: 32px !important;


Line should be indented with spaces, not tabs
!important should not be used
Properties should be ordered color, padding-left

houndci-bot · 2017-12-03T19:42:06Z

client/src/app/css/style.scss

+ * Collapsible
+ */
+.collapsible {
+	background-color: $base-orange;


Line should be indented with spaces, not tabs

houndci-bot · 2017-12-03T20:03:26Z

client/src/app/components/container/common/Pagination.jsx

  render() {
    return (
      <Row>
-        <Pagination onSelect={this.onSelect} {...this.props.config}  maxButtons= {5}/>
+        <Pagination onSelect={this.onSelect} {...this.props.config} maxButtons={5} />


'config' is missing in props validation react/prop-types

houndci-bot · 2017-12-03T20:03:26Z

client/src/app/components/presentation/Dashboard.jsx

@@ -1,5 +1,5 @@
 import React from 'react';
-import { Row, Icon, Col } from 'react-materialize';
+import { Row } from 'react-materialize';


Unable to resolve path to module 'react-materialize' import/no-unresolved
Missing file extension for "react-materialize" import/extensions

houndci-bot · 2017-12-03T20:03:26Z

client/src/app/components/presentation/common/book/BookModal.jsx

+              <div className="book-modal">Description: <span id="bookDescription" /></div>
+            </Col>
+          </div>
+          {this.props.children}


'children' is missing in props validation react/prop-types

houndci-bot · 2017-12-03T20:03:26Z

client/src/app/components/presentation/common/book/BookModal.jsx

+   * @memberOf BookModal
+   */
+  render() {
+    const { header, actions } = this.props;


'header' is missing in props validation react/prop-types
'actions' is missing in props validation react/prop-types

houndci-bot · 2017-12-03T20:03:26Z

client/src/app/components/presentation/common/book/BookModal.jsx

+ * @extends {React.Component}
+ */
+class BookModal extends React.Component {
+  constructor(props) {


Useless constructor no-useless-constructor
Missing JSDoc comment require-jsdoc

houndci-bot · 2017-12-03T20:03:27Z

client/src/app/components/container/categories/getCategoriesWrapper.jsx

@@ -0,0 +1,86 @@
+import React from 'react';
+import PropTypes from 'prop-types';


Unable to resolve path to module 'prop-types' import/no-unresolved
Missing file extension for "prop-types" import/extensions

houndci-bot · 2017-12-03T20:03:27Z

client/src/app/components/container/categories/getCategoriesWrapper.jsx

@@ -0,0 +1,86 @@
+import React from 'react';


Unable to resolve path to module 'react' import/no-unresolved
Missing file extension for "react" import/extensions

houndci-bot · 2017-12-03T20:03:27Z

client/src/app/components/presentation/common/SideNav/index.jsx

@@ -1,8 +1,11 @@
 import React from 'react';
 import PropTypes from 'prop-types';
 import UserView from './UserView.jsx';
+import CategoriesSideBar from '../../../container/categories/CategoriesSideBar.jsx';
+import getCategories from '../../../container/categories/getCategoriesWrapper.jsx';


Unable to resolve path to module '../../../container/categories/getCategoriesWrapper.jsx' import/no-unresolved
Unexpected use of file extension "jsx" for "../../../container/categories/getCategoriesWrapper.jsx" import/extensions

houndci-bot · 2017-12-03T20:03:27Z

client/src/app/components/presentation/common/SideNav/index.jsx

@@ -1,8 +1,11 @@
 import React from 'react';
 import PropTypes from 'prop-types';
 import UserView from './UserView.jsx';
+import CategoriesSideBar from '../../../container/categories/CategoriesSideBar.jsx';


Unable to resolve path to module '../../../container/categories/CategoriesSideBar.jsx' import/no-unresolved
Unexpected use of file extension "jsx" for "../../../container/categories/CategoriesSideBar.jsx" import/extensions

houndci-bot · 2017-12-03T20:03:27Z

client/src/app/components/container/booklist/DisplayBorrowedBooks.jsx

 import PaginationWrapper from '../common/Pagination.jsx';
 import Book from '../../presentation/common/book/DisplayBook.jsx';
+import Loader from './Loader.jsx';


Unable to resolve path to module './Loader.jsx' import/no-unresolved
Unexpected use of file extension "jsx" for "./Loader.jsx" import/extensions

coveralls · 2017-12-03T20:06:06Z

Changes Unknown when pulling 071d15f on feature/153149518/users-should-be-able-to-view-book-categories into ** on development**.

Benny Ogidan added 2 commits December 3, 2017 20:17

feature(categories): Users can categorize all books

aae67e2

- Categorization of books implemented - List of categories of books implemented - Search functionality implemented

[Delivers #153149518]

b593445

houndci-bot reviewed Dec 3, 2017

View reviewed changes

chore (refactoring tests): Change for the tests

071d15f

houndci-bot reviewed Dec 3, 2017

View reviewed changes

benfluleck merged commit b36be1c into development Dec 3, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Users can categorize all books #38

Users can categorize all books #38

benfluleck commented Dec 3, 2017 •

edited

Loading

houndci-bot Dec 3, 2017

houndci-bot Dec 3, 2017

houndci-bot Dec 3, 2017

houndci-bot Dec 3, 2017

houndci-bot Dec 3, 2017

houndci-bot Dec 3, 2017

houndci-bot Dec 3, 2017

houndci-bot Dec 3, 2017

houndci-bot Dec 3, 2017

houndci-bot Dec 3, 2017

houndci-bot Dec 3, 2017

houndci-bot Dec 3, 2017

houndci-bot Dec 3, 2017

houndci-bot Dec 3, 2017

houndci-bot Dec 3, 2017

houndci-bot Dec 3, 2017

houndci-bot Dec 3, 2017

houndci-bot Dec 3, 2017

houndci-bot Dec 3, 2017

houndci-bot Dec 3, 2017

coveralls commented Dec 3, 2017

		@@ -0,0 +1,15 @@
		import React from 'react';
		import { Row } from 'react-materialize';

		@@ -0,0 +1,86 @@
		import React from 'react';
		import PropTypes from 'prop-types';

Users can categorize all books #38

Users can categorize all books #38

Conversation

benfluleck commented Dec 3, 2017 • edited Loading

Description

Screenshots (if appropriate):

Any background context you want to provide?

What are the relevant pivotal tracker stories?

Types of changes

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Dec 3, 2017

benfluleck commented Dec 3, 2017 •

edited

Loading