bug-fix for materialize modals #43

benfluleck · 2017-12-18T03:20:18Z

Description

The current iteration of materialize css has an issue with overlay from modals causing breakings errors. To overcome this problem I have installed react 16 as advised by a github forum.

https://github.com/react-materialize/react-materialize/issues/433

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
New chore (expected functionality to be implemented)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.

…t materialize modal bug - Refactored code by implementingmore Jsdocs

houndci-bot · 2017-12-18T03:20:39Z

client/src/app/mainRoot.jsx

@@ -3,7 +3,7 @@ import 'redux-notifications/lib/styles.css';
 import { BrowserRouter as Router, Route, Switch } from 'react-router-dom';
 import Root from './components/Root.jsx';
 import LandingPage from './components/container/LandingPage.jsx';
-import Login from './components/presentation/authentication/SignInPage.jsx';
+import SignInPage from './components/presentation/authentication/SignInPage.jsx';


Line 6 exceeds the maximum line length of 80 max-len
Unexpected use of file extension "jsx" for "./components/presentation/authentication/SignInPage.jsx" import/extensions

houndci-bot · 2017-12-18T03:20:40Z

client/src/app/css/style.scss

+	border: 1px solid transparent;
+	font-size: 16px;
+	font-weight: bold;
+


Line contains trailing whitespace

houndci-bot · 2017-12-18T03:20:40Z

client/src/app/css/style.scss

+	border-radius: 2px;
+	border: 1px solid transparent;
+	font-size: 16px;
+	font-weight: bold;


Line should be indented with spaces, not tabs

houndci-bot · 2017-12-18T03:20:40Z

client/src/app/css/style.scss

+	padding-bottom: 10px;
+	border-radius: 2px;
+	border: 1px solid transparent;
+	font-size: 16px;


Line should be indented with spaces, not tabs

houndci-bot · 2017-12-18T03:20:40Z

client/src/app/css/style.scss

+	color: rgb(255, 255, 255);
+	padding-bottom: 10px;
+	border-radius: 2px;
+	border: 1px solid transparent;


Line should be indented with spaces, not tabs

houndci-bot · 2017-12-18T03:20:41Z

client/src/app/css/style.scss

@@ -330,10 +330,23 @@ i.medium {
 .loan-button {
 	margin-right: 14px !important;
 }
-.btn-google {
-	background-color: #dd4b39;
+.btn-google, .google-btn{


Each selector in a comma sequence should be on its own single line
Opening curly brace { should be preceded by one space

houndci-bot · 2017-12-18T03:20:41Z

client/src/app/components/presentation/common/modal/ChangeUserLevelModal.jsx

-import { changeUserLevelAction } from
-  '../../../../actions/admin/changeUserLevel';
+import { getUserLevelListAction } from '../../../../actions/admin/getUserLevelList';
+import { changeUserLevelAction } from '../../../../actions/admin/changeUserLevel';


Line 6 exceeds the maximum line length of 80 max-len
Missing file extension for "../../../../actions/admin/changeUserLevel" import/extensions

houndci-bot · 2017-12-18T03:20:41Z

client/src/app/components/presentation/common/modal/ChangeUserLevelModal.jsx

-  from '../../../../actions/admin/getUserLevelList';
-import { changeUserLevelAction } from
-  '../../../../actions/admin/changeUserLevel';
+import { getUserLevelListAction } from '../../../../actions/admin/getUserLevelList';


Line 5 exceeds the maximum line length of 80 max-len
Missing file extension for "../../../../actions/admin/getUserLevelList" import/extensions

houndci-bot · 2017-12-18T03:20:41Z

client/src/app/components/presentation/authentication/SignInPage.jsx

@@ -162,19 +169,18 @@ class SignInPage extends Component {
                    <a className="btn btn-social btn-google">
                      <span className="fa fa-google" />
                      <GoogleLogin
+                       className="google-btn"


Expected indentation of 24 space characters but found 23 react/jsx-indent-props

houndci-bot · 2017-12-18T03:20:41Z

client/src/app/components/presentation/authentication/SignInPage.jsx

-          return this.props.history.push('/admin');
+      .then((response) => {
+        if (response.success && response.isAdmin) {
+          return (this.props.history.push('/admin'));


'history' is missing in props validation react/prop-types
'history.push' is missing in props validation react/prop-types

houndci-bot · 2017-12-18T03:20:42Z

client/src/app/mainRoot.jsx

@@ -3,7 +3,7 @@ import 'redux-notifications/lib/styles.css';
 import { BrowserRouter as Router, Route, Switch } from 'react-router-dom';
 import Root from './components/Root.jsx';
 import LandingPage from './components/container/LandingPage.jsx';
-import Login from './components/presentation/authentication/SignInPage.jsx';
+import SignInPage from './components/presentation/authentication/SignInPage.jsx';


Line 6 exceeds the maximum line length of 80 max-len
Unexpected use of file extension "jsx" for "./components/presentation/authentication/SignInPage.jsx" import/extensions

houndci-bot · 2017-12-18T03:20:42Z

client/src/app/css/style.scss

+	border: 1px solid transparent;
+	font-size: 16px;
+	font-weight: bold;
+


Line contains trailing whitespace

houndci-bot · 2017-12-18T03:20:42Z

client/src/app/css/style.scss

+	border-radius: 2px;
+	border: 1px solid transparent;
+	font-size: 16px;
+	font-weight: bold;


Line should be indented with spaces, not tabs

houndci-bot · 2017-12-18T03:20:42Z

client/src/app/css/style.scss

+	padding-bottom: 10px;
+	border-radius: 2px;
+	border: 1px solid transparent;
+	font-size: 16px;


Line should be indented with spaces, not tabs

houndci-bot · 2017-12-18T03:20:42Z

client/src/app/css/style.scss

+	color: rgb(255, 255, 255);
+	padding-bottom: 10px;
+	border-radius: 2px;
+	border: 1px solid transparent;


Line should be indented with spaces, not tabs

houndci-bot · 2017-12-18T03:20:43Z

client/src/app/css/style.scss

@@ -330,10 +330,23 @@ i.medium {
 .loan-button {
 	margin-right: 14px !important;
 }
-.btn-google {
-	background-color: #dd4b39;
+.btn-google, .google-btn{


Each selector in a comma sequence should be on its own single line
Opening curly brace { should be preceded by one space

houndci-bot · 2017-12-18T03:20:43Z

client/src/app/components/presentation/common/modal/ChangeUserLevelModal.jsx

-import { changeUserLevelAction } from
-  '../../../../actions/admin/changeUserLevel';
+import { getUserLevelListAction } from '../../../../actions/admin/getUserLevelList';
+import { changeUserLevelAction } from '../../../../actions/admin/changeUserLevel';


Line 6 exceeds the maximum line length of 80 max-len
Missing file extension for "../../../../actions/admin/changeUserLevel" import/extensions

houndci-bot · 2017-12-18T03:20:43Z

client/src/app/components/presentation/common/modal/ChangeUserLevelModal.jsx

-  from '../../../../actions/admin/getUserLevelList';
-import { changeUserLevelAction } from
-  '../../../../actions/admin/changeUserLevel';
+import { getUserLevelListAction } from '../../../../actions/admin/getUserLevelList';


Line 5 exceeds the maximum line length of 80 max-len
Missing file extension for "../../../../actions/admin/getUserLevelList" import/extensions

houndci-bot · 2017-12-18T03:20:43Z

client/src/app/components/presentation/authentication/SignInPage.jsx

@@ -162,19 +169,18 @@ class SignInPage extends Component {
                    <a className="btn btn-social btn-google">
                      <span className="fa fa-google" />
                      <GoogleLogin
+                       className="google-btn"


Expected indentation of 24 space characters but found 23 react/jsx-indent-props

houndci-bot · 2017-12-18T03:20:43Z

client/src/app/components/presentation/authentication/SignInPage.jsx

-          return this.props.history.push('/admin');
+      .then((response) => {
+        if (response.success && response.isAdmin) {
+          return (this.props.history.push('/admin'));


'history' is missing in props validation react/prop-types
'history.push' is missing in props validation react/prop-types

coveralls · 2017-12-18T03:24:16Z

Coverage remained the same at 90.444% when pulling 9d79b93 on chore/153665644/implement-client-side-testing into 93642cd on development.

Benny Ogidan added 2 commits December 17, 2017 18:00

chore (untracked files): check un-tracked files

9689cf9

bug-fix (materialize modal bug): Installed react 16 to eliminate reac…

9d79b93

…t materialize modal bug - Refactored code by implementingmore Jsdocs

houndci-bot reviewed Dec 18, 2017

View reviewed changes

benfluleck merged commit f74ec92 into development Dec 18, 2017

benfluleck temporarily deployed to staging-hellobooks December 18, 2017 03:45 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bug-fix for materialize modals #43

bug-fix for materialize modals #43

benfluleck commented Dec 18, 2017

houndci-bot Dec 18, 2017

houndci-bot Dec 18, 2017

houndci-bot Dec 18, 2017

houndci-bot Dec 18, 2017

houndci-bot Dec 18, 2017

houndci-bot Dec 18, 2017

houndci-bot Dec 18, 2017

houndci-bot Dec 18, 2017

houndci-bot Dec 18, 2017

houndci-bot Dec 18, 2017

houndci-bot Dec 18, 2017

houndci-bot Dec 18, 2017

houndci-bot Dec 18, 2017

houndci-bot Dec 18, 2017

houndci-bot Dec 18, 2017

houndci-bot Dec 18, 2017

houndci-bot Dec 18, 2017

houndci-bot Dec 18, 2017

houndci-bot Dec 18, 2017

houndci-bot Dec 18, 2017

coveralls commented Dec 18, 2017

bug-fix for materialize modals #43

bug-fix for materialize modals #43

Conversation

benfluleck commented Dec 18, 2017

Description

Types of changes

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Dec 18, 2017