Fix/implementation of feedback from scorecard #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed UserView andela link as advised - re-added code climate badge - changed the seed user images to https images to remove Heroku warnings - added Image to repository to improve allure
- Refactored tests to pass by using a constant variable
houndci-bot
reviewed
Jan 5, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Cannot find module 'eslint-config-react'
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
at ModuleResolver.resolve (/app/node_modules/eslint/lib/util/module-resolver.js:74:19)
at resolve (/app/node_modules/eslint/lib/config/config-file.js:515:25)
at load (/app/node_modules/eslint/lib/config/config-file.js:584:26)
at configExtends.reduceRight (/app/node_modules/eslint/lib/config/config-file.js:421:36)
at Array.reduceRight ()
at applyExtends (/app/node_modules/eslint/lib/config/config-file.js:403:28)
at loadFromDisk (/app/node_modules/eslint/lib/config/config-file.js:556:22)
at Object.load (/app/node_modules/eslint/lib/config/config-file.js:592:20)
at Config.getLocalConfigHierarchy (/app/node_modules/eslint/lib/config.js:226:44)
at Config.getConfigHierarchy (/app/node_modules/eslint/lib/config.js:180:43)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added screen shot to Readme.md
Fixed eslint errors in application
Refactored test cases using a testdate by changing the variable to a constant
Refactored Api docs to remove Change User levels tab
Types of changes
Checklist: