Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (serialization of state): Changing the state object to a new vari… #48

Conversation

benfluleck
Copy link
Owner

Description

  • fix for Google Authentication so google auth users sign up on sign in and then the app logs them in
  • shortening of userId that displayed on the website
  • toast on Logout
  • refactoring of the controller to reduce unwanted attributes from the server

What does this PR do?

Screenshots (if appropriate):

Any background context you want to provide?

What are the relevant pivotal tracker stories?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

…able

- fix for google Authentication so google auth users sign up on sign in and then the app logs them in
- shortenting of userId that displayed on website
- toast on Logout
- refactoring of controller to reduce unwanted attricutes from the server
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot find module 'eslint-config-react'
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
    at ModuleResolver.resolve (/app/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/app/node_modules/eslint/lib/config/config-file.js:515:25)
    at load (/app/node_modules/eslint/lib/config/config-file.js:584:26)
    at configExtends.reduceRight (/app/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight ()
    at applyExtends (/app/node_modules/eslint/lib/config/config-file.js:403:28)
    at loadFromDisk (/app/node_modules/eslint/lib/config/config-file.js:556:22)
    at Object.load (/app/node_modules/eslint/lib/config/config-file.js:592:20)
    at Config.getLocalConfigHierarchy (/app/node_modules/eslint/lib/config.js:226:44)
    at Config.getConfigHierarchy (/app/node_modules/eslint/lib/config.js:180:43)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 92.671% when pulling f14901a on chore/154109353/implement-changes-to-controllers-by-returning-only-needed-attributes into b4155c7 on development.

@benfluleck benfluleck merged commit ce3a71a into development Jan 6, 2018
@benfluleck benfluleck added the bug label Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants