Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py-spy should support --idle in top #406

Closed
wwoods opened this issue Jun 21, 2021 · 2 comments · Fixed by #411
Closed

py-spy should support --idle in top #406

wwoods opened this issue Jun 21, 2021 · 2 comments · Fixed by #411

Comments

@wwoods
Copy link

wwoods commented Jun 21, 2021

The --idle argument for record is really helpful in diagnosing e.g. network-related bottlenecks. Often times, it is faster and more convenient to use the top command rather than the record command on remote machines. Therefore, it would be helpful if top accepted --idle.
benfred added a commit that referenced this issue Jun 27, 2021
@benfred
Add --gil and --idle options to the top subcommand
dfc9d24 
This change allows you to pass --idle and --gil commands to the top
command as well as the record command. This lets you view all samples
or samples that hold the gil in the 'top' tui the same as you can
with the record subcommand

Closes #406
@benfred benfred mentioned this issue Jun 27, 2021
Merged
@benfred
Copy link
Owner

benfred commented Jun 27, 2021

thanks for the suggestion! I've implemented in #411

benfred added a commit that referenced this issue Jun 27, 2021
@benfred
Add --gil and --idle options to the top subcommand (#411)
5c2b354 
This change allows you to pass --idle and --gil commands to the top
command as well as the record command. This lets you view all samples
or samples that hold the gil in the 'top' tui the same as you can
with the record subcommand

Closes #406
@wwoods
Copy link
Author

wwoods commented Jun 28, 2021

Thanks! py-spy is great, really appreciate you making / maintaining it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add --gil and --idle options to the top subcommand benfred/py-spy
2 participants
@benfred @wwoods