fix some wrong usage of the && operator. It should be & instead. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 28 commits
April 7, 2019 17:11
…niversal binaries
…ears now, there's no need for universal binaries. Every Mac since than can run 64-bit apps. With macOS 10.15 and above this will be the only arch, 32bit apps will no longer be supported.
… There is never any need using a dpi value, when using pictures on a computer display. Only pixel dimensions do matter. If this code was inteded for use with retina Macs, it's of no use too, because macOS takes care of any scaling needed. In fact, the current scaling code produces 2x upscaled cover art on retina Mac. So, the all code related to scaling on macOS is removed now.
…ed scaling code on macOS.
…oved scaling code on macOS.
…is already removed.
…des into the file. This results in incompatible files not playable in iTunes. E.g. see https://bitbucket.org/wez/atomicparsley/issues/54/itunes-wont-import-hevc-mp4-run-through
…Par_SupplySelectiveTypeCreatorCodes() which was of no use and in fact caused unplayable mp4 files.
…s simply interpreted the iso-8859-1 source code as utf8 and so messed up all atom names containing a ©.
…s simply interpreted the iso-8859-1 source code as utf8 and so messed up all atom names containing a ©.
…TFORM from CFLAGS and CXXFLAGS
…TFORM from CFLAGS and CXXFLAGS
|
Thanks; it looks like that pull might be based on a different repo than this one? I pulled out what looked like the && to & changes with 005edbd so this should be resolved. For what it's worth, this isn't my project; it's just a fork that I was doing for my own use. I'd get in touch with the original developer(s) (link at the top of the README) for actual fixes. |
wez
added a commit
to wez/atomicparsley
that referenced
this pull request
Jul 1, 2020
Credit to @lisanet refs: benfry/atomicparsley#1
wez
added a commit
to wez/atomicparsley
that referenced
this pull request
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using && with a const always returns true. This should be the & operator instead.
There were a few deprecated functions and methods with give warnings on mac os 10.14.