Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extra space between lines #5

Closed
angea opened this issue Jun 15, 2016 · 6 comments
Closed

add extra space between lines #5

angea opened this issue Jun 15, 2016 · 6 comments
Assignees
Labels
enhancement An improvement of an existing feature

Comments

@angea
Copy link

angea commented Jun 15, 2016

My retro side is telling me it's against the rules,
but an option to add a few extra pixels between each lines would increase readability
and would satisfy my visual side ;)

@bengarrett bengarrett added the enhancement An improvement of an existing feature label Jun 17, 2016
@bengarrett bengarrett self-assigned this Jun 17, 2016
@bengarrett
Copy link
Owner

Don't worry IMO there are few rules when it comes to retro PCs.

It would be easy enough to implement using the line-height CSS property.

Are you happy with the font size? Because in Chrome you can use Ctrl + to enlarge the text per tab which also increases the line spacing.

@angea
Copy link
Author

angea commented Jun 17, 2016

yes, I use the Chrome zoom to change the size, so that it goes to full width.
The line spacing increases of course but the readability stays the same.

On Fri, Jun 17, 2016 at 10:50 AM, Ben Garrett notifications@github.com wrote:

Don't worry IMO there are few rules when it comes to retro PCs.

It would be easy enough to implement using the line-height CSS property.

Are you happy with the font size? Because in Chrome you can use Ctrl + to
enlarge the text per tab which also increases the line spacing.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@bengarrett
Copy link
Owner

bengarrett commented Jun 17, 2016

Okay thanks, do you have a preference, line height vs increased font size?

As I think the Chrome API allows extensions to apply separate zoom settings per-tab. So it should be possible to add an option to allow users to apply a default zoom size on all pages/text files rendered in RetroTxt.

@angea
Copy link
Author

angea commented Jun 18, 2016

it's 2 different aspects IMHO: zoom depends on your screen (even when using
multiple screens on the same computer) so IMHO it shouldn't be handled by
the extension, but line height is like shadow:
it increases readability.

so can you make an option to set 0/1/2 extra pixels (as in, font pixel, not
displayed pixel) of spaces between lines ?

On Sat, Jun 18, 2016 at 1:45 AM, Ben Garrett notifications@github.com
wrote:

Okay thanks, do you have a preference, line height vs increased font size?

As I think the Chrome API allows extensions to apply separate zoom
settings per-tab. So it should be possible to add an option to allow users
to apply a default zoom on all pages/text files rendered in RetroTxt.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#5 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AFXSWxwQkw1Zh11-RhBi6gCVf0ef6Nf6ks5qMzGPgaJpZM4I2v21
.

@bengarrett
Copy link
Owner

Thanks for clarifying that and the suggestion. I'll look at adding that option in the next release.

@angea
Copy link
Author

angea commented Jun 29, 2016

awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants