Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build doesn't work on mac #18

Closed
bengreenier opened this issue Sep 5, 2018 · 0 comments
Closed

Build doesn't work on mac #18

bengreenier opened this issue Sep 5, 2018 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
1.0.0 Release

Comments

@bengreenier
Copy link
Owner

As per @noopkat's test, the build script for static things (build-static) doesn't work on Mac :( - we should repro and fix that!
@bengreenier bengreenier added the bug Something isn't working label Sep 5, 2018
@bengreenier bengreenier added this to the 1.0.0 Release milestone Sep 5, 2018
@bengreenier bengreenier added the good first issue Good for newcomers label Sep 6, 2018
vimkat added a commit to vimkat/overlayed that referenced this issue Sep 14, 2018
@vimkat
Fixed failing build on macOS 🐛 (bengreenier#18)
a328d74 
Apparently, the `echo` command doesn't like parentheses, if they are not
wrapped in quotes. Mac users can now happily build again! 🎉
@vimkat vimkat mentioned this issue Sep 14, 2018
Merged
vimkat added a commit to vimkat/overlayed that referenced this issue Sep 14, 2018
@vimkat
Build steps ran in parallel when the should run in series 🐛 (bengreen…
e789d8c 
…ier#18)

Due to this, builds sometimes just failed out of nowhere or the `dist`
directory was empty after a rebuild.
bengreenier pushed a commit that referenced this issue Sep 21, 2018
@vimkat @bengreenier
Fixed failing build on macOS 🐛 (#27)
bdd0941 
* Fixed failing build on macOS 🐛 (#18)

Apparently, the `echo` command doesn't like parentheses, if they are not
wrapped in quotes. Mac users can now happily build again! 🎉

* Build steps ran in parallel when the should run in series 🐛 (#18)

Due to this, builds sometimes just failed out of nowhere or the `dist`
directory was empty after a rebuild.

* move to javascript file :/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
1.0.0 Release
Development

No branches or pull requests
1 participant
@bengreenier