Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export format Homeass-Broadlink IR #477

Closed
bengtmartensson opened this issue Feb 3, 2023 · 2 comments
Closed

Fix export format Homeass-Broadlink IR #477

bengtmartensson opened this issue Feb 3, 2023 · 2 comments

Comments

@bengtmartensson
Copy link
Owner

Said export format is broken and to be fixed.

In the future extend for 433 MHz RF.

@GMichu
Copy link

GMichu commented Feb 12, 2023

How is this export format broken? I found this wonderful project while looking for a way to convert various formats into homeass-broadlink. So far, I have not encountered problems, so I ask to know what to look out for.

@bengtmartensson
Copy link
Owner Author

First, the lenght parameter in the data is wrong: just counts the number of unencoded durations instead of the number of bytes after the 1--2 byte coding. Secondly, the command names were wrong, I think they were all called power_on or power_off or so.

I just checked in a partial fix; fixes the second problem but not the first one. (You can just drop the file https://raw.githubusercontent.com/bengtmartensson/IrScrutinizer/master/src/main/config/exportformats.d/Homeass_broadlink.xml into your exportformats.d directory, and you will be set.) It is possible that the reading programs or hardware does not check the lenght. Please give feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants