Code cleanup #49
Merged
Code cleanup #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
err,, isnt the decision usually 2 spaces for a tab ? Merry 🎄 |
|
Well, I noticed that 4 was sort of the going thing, I can easily change it to 2 |
|
So with 2 spaces and with 4: |
|
Looks great! |
|
Looks good. I just changed my editor to use four spaces for tabs for this --gp On Tue, Dec 24, 2013 at 9:24 PM, LoadFive notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major source update Pinging @loadfive @gprasant for feedback.
While working on knwl.js I noticed a great deal of the tabbing was all over the place. I have gone though and enforced everything is 4 spaces for a tab. This means alot of the code is now much more readable on how "deep" you are.
I also replaced all uses of
alertwithconsole.errorso that if/when we move to a node module or something that could be compatible with node. It will be a lot smoother.
I also made sure that all the multidimensional array's are spaced out more, making appending to them a great deal more easy.
Overall I think this will greatly improve the code readability of the whole project!
Have a great xmas 🎄
as a major side note, it is worth merging this one last before anyone else's PR's to avoid death by merge conflicts