Better filenames tracking - #153
Merged
Merged
Conversation
Contributor
Author
|
@benhoyt Any thoughts? |
Owner
|
Yes, sorry, last week was a busy week. I'll try to get to this tonight or tomorrow. |
benhoyt
requested changes
Sep 28, 2022
benhoyt
left a comment
benhoyt
left a comment
Owner
There was a problem hiding this comment.
Thanks for this. Looks good overall! Requesting a few minor changes and some additional test cases.
This reverts commit 00df7cd.
Contributor
Author
|
Done. Please check if it's ok now. |
Owner
|
Merged, thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the other PR in context of #144.
This is re-implemenation of #150 based on work in #151. I think #151 can be just closed.
Basically this is almost equivalent to #151 plus: