cmake build #105
cmake build #105
Conversation
|
Hi - thanks for the contribution. I'm pretty uncertain about including all different build systems (especially for a tiny single-file library). For a start, it adds a bunch of noise files to the repo, and second, I'm not at all familiar with CMake so would have trouble reviewing this change. |
| prefix=@prefix@ | ||
| exec_prefix=${prefix} | ||
| libdir=@libdir@ | ||
| includedir=@includedir@ | ||
|
|
||
| Name: inih | ||
| Version: @PACKAGE_VERSION@ | ||
| Description: ZeroMQ libuv. | ||
| URL: https://github.com/MerlinXYoung/inih | ||
|
|
||
| Libs: -L${libdir} -linih @LIBS@ | ||
| Cflags: -I${includedir} |
There was a problem hiding this comment.
pkg-config files are already created by Meson, no need to add them to CMake.
| .vscode | ||
| build |
There was a problem hiding this comment.
Nothing that should be in an upstream git repo IMHO.
| LIBRARY DESTINATION lib/$<CONFIG> | ||
| ARCHIVE DESTINATION lib/$<CONFIG> | ||
| ) | ||
| endif() |
| configure_file(INIReader.pc.in INIReader.pc @ONLY) | ||
|
|
||
| install(TARGETS inih INIReader | ||
| RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} |
There was a problem hiding this comment.
I don't entirely get why there needs a bindir needs to be set.
|
Overall I don't see why there needs to be a second build system, Meson is already there. Meson works under macOS, Windows, Linux and possibly every OS that can run Python. |
|
Closing due to lack of response, and I'd rather this were not included anyway due to me being unable to maintain N build systems. |
cmake build