enable distro settings by default #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhoyt
approved these changes
Feb 6, 2021
Signed-off-by: Stephan Lachnit <stephanlachnit@protonmail.com>
See also benhoyt#123. Signed-off-by: Stephan Lachnit <stephanlachnit@protonmail.com>
stephanlachnit
force-pushed
the
p/default_library
branch
from
02b99b6
to
dc335a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inih as a shared library becomes increasingly popular and is even used by xfsprogs now. Because of that, I think it's a good idea to enable these settings in Meson by default. Since Meson supports individual settings per subproject, this won't break any use case.
I also added a small note so that issues like #123 don't appear again.