Generate plan Copy and Merge methods #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note the subtle bug this fixes in Check.Copy! copied -> c
The Name and Override fields are now copied, but this doesn't hurt (maps of structs are merged by name, so the name is always the same, and it doesn't hurt to copy Override where it wasn't copied before). Note that this fixes a couple of bugs: * Service.Requires wasn't being copied! * The Service.UserID and .GroupID pointers were being copied, but it's better to copy the value (deep copy) in case the caller changes it.
|
After further discussion via video, we've decided to use the reflect-based approach instead (unless or until we need special-cases for the various fields, in which case we'll probably revert to hand-rolled logic). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See canonical#97 for full context and description.